Add tests for the CachedResourceNameCollectionFactory class#828
Merged
dunglas merged 1 commit intoNov 6, 2016
Conversation
Member
meyerbaptiste
commented
Nov 4, 2016
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | N/A |
| License | MIT |
| Doc PR | N/A |
meyerbaptiste
commented
Nov 4, 2016
| } catch (CacheException $e) { | ||
| // do nothing | ||
| } | ||
| $cacheItem->set($resourceNameCollection); |
Member
Author
There was a problem hiding this comment.
IMHO there is no reason to catch a CacheException exception here because CacheItemPoolInterface::save() and CacheItemInterface::set() methods are not planning to throw an exception in their method definitions.
8c475f3 to
340345b
Compare
340345b to
3940dc4
Compare
Member
|
Thanks @meyerbaptiste |
Contributor
|
We should do the same for all the other cached factories then. |
magarzon
pushed a commit
to magarzon/core
that referenced
this pull request
Feb 12, 2017
…ed_resource_name_collection_factory Add tests for the CachedResourceNameCollectionFactory class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.