Thanks to visit codestin.com
Credit goes to github.com

ArduinoCore-avr_I2C_timeout_added #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

AbhishekGS-MW wants to merge 9 commits into arduino:master from mathworks:master

AbhishekGS-MW commented Feb 12, 2019

To make sure that I2C read write operations does not get stuck in an infinite loop, a timeout has been added.

AbhishekGS-MW added 8 commits

February 12, 2019 12:24


          Create README.md

a7822cf


          Update README.md

b1d3bae


          Update twi.c

07eb568


          Update twi.h

656471e

Added the declaration of the timeout function used in I2C operations.


          Update README.md

c8e50da


          Update README.md

03bae9d


          Create LICENSE

bbd9ce3


          Merge pull request #1 from AbhishekGS-MW/add-license-1

3352f9e

Create LICENSE

MCUdude commented Feb 12, 2019

You should use ISR, not SIGNAL.

You also need to replace tabs with spaces


          Update README.md

dd1b23c

per1234 requested changes

View reviewed changes

libraries/Wire/src/utility/twi.c

		while(TWI_MRX == twi_state){
		if (twi_timeout(0)) break;

Contributor

per1234 Feb 13, 2019

Suggested change

      
                if (twi_timeout(0)) break;  
          
                if (twi_timeout(0)) break;

libraries/Wire/src/utility/twi.c

                 while(TWI_READY != twi_state){
+                  if (twi_timeout(0))
+              	{

Contributor

per1234 Feb 13, 2019

Please follow the formatting style of the rest of the code in the file and attach this brace to the if statement.

libraries/Wire/src/utility/twi.c

                 while(TWI_READY != twi_state){
+                  if (twi_timeout(0))
+              	{
+              		return 32;

Contributor

per1234 Feb 13, 2019

Suggested change

libraries/Wire/src/utility/twi.c

+                  if (twi_timeout(0))
+              	{
+              		return 32;
+              	}

Contributor

per1234 Feb 13, 2019

Suggested change

libraries/Wire/src/utility/twi.c

                   TWCR = _BV(TWINT) | _BV(TWEA) | _BV(TWEN) | _BV(TWIE);	// enable INTs, but not START
                 }
                 else
-                  // send start condition
+                // send start condition

Contributor

per1234 Feb 13, 2019

Suggested change

      
              // send start condition
          
                // send start condition

libraries/Wire/src/utility/twi.c

+              		twi_timer_count=0;
+              		// reinitialize the hardware
+              		twi_init();
+              		return 1;

Contributor

per1234 Feb 13, 2019

Suggested change

      
            		return 1;
          
                return 1;

libraries/Wire/src/utility/twi.c

+              		// reinitialize the hardware
+              		twi_init();
+              		return 1;
+              	}

Contributor

per1234 Feb 13, 2019

Suggested change

libraries/Wire/src/utility/twi.c

+              		twi_init();
+              		return 1;
+              	}
+                  return 0;

Contributor

per1234 Feb 13, 2019

Suggested change

      
                return 0;  
          
              return 0;

LICENSE

		@@ -0,0 +1,512 @@
		This file includes license information for arduino avr core. The code has been forked

Contributor

per1234 Feb 13, 2019

Remove this file from the PR.

README.md

		@@ -0,0 +1,8 @@

Contributor

per1234 Feb 13, 2019

Remove this file from the PR.

aentinger force-pushed the master branch from 1a6eb5e to c0b0803 Compare

September 18, 2019 11:22

CLAassistant commented Apr 9, 2021

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet