Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ArduinoCore-avr_I2C_timeout_added #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

ArduinoCore-avr_I2C_timeout_added #74

wants to merge 9 commits into from

Conversation

@AbhishekGS-MW
Copy link

@AbhishekGS-MW AbhishekGS-MW commented Feb 12, 2019

To make sure that I2C read write operations does not get stuck in an infinite loop, a timeout has been added.

@MCUdude
Copy link

MCUdude commented Feb 12, 2019

You should use ISR, not SIGNAL.

You also need to replace tabs with spaces

per1234
per1234 requested changes Feb 13, 2019
View reviewed changes
libraries/Wire/src/utility/twi.c
// wait for read operation to complete
twi_timeout(1);
while(TWI_MRX == twi_state){
if (twi_timeout(0)) break;
Copy link
Contributor

@per1234 per1234 Feb 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (twi_timeout(0)) break;
if (twi_timeout(0)) break;

libraries/Wire/src/utility/twi.c
twi_timeout(1);
while(TWI_READY != twi_state){
if (twi_timeout(0))
{
Copy link
Contributor

@per1234 per1234 Feb 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the formatting style of the rest of the code in the file and attach this brace to the if statement.

libraries/Wire/src/utility/twi.c
while(TWI_READY != twi_state){
if (twi_timeout(0))
{
return 32;
Copy link
Contributor

@per1234 per1234 Feb 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return 32;
return 32;

libraries/Wire/src/utility/twi.c
if (twi_timeout(0))
{
return 32;
}
Copy link
Contributor

@per1234 per1234 Feb 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
}

libraries/Wire/src/utility/twi.c
}
else
// send start condition
// send start condition
Copy link
Contributor

@per1234 per1234 Feb 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// send start condition
// send start condition

libraries/Wire/src/utility/twi.c
twi_timer_count=0;
// reinitialize the hardware
twi_init();
return 1;
Copy link
Contributor

@per1234 per1234 Feb 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return 1;
return 1;

libraries/Wire/src/utility/twi.c
// reinitialize the hardware
twi_init();
return 1;
}
Copy link
Contributor

@per1234 per1234 Feb 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
}

libraries/Wire/src/utility/twi.c
twi_init();
return 1;
}
return 0;
Copy link
Contributor

@per1234 per1234 Feb 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return 0;
return 0;

LICENSE
@@ -0,0 +1,512 @@
This file includes license information for arduino avr core. The code has been forked
Copy link
Contributor

@per1234 per1234 Feb 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file from the PR.

README.md
@@ -0,0 +1,8 @@

Copy link
Contributor

@per1234 per1234 Feb 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file from the PR.

@CLAassistant
Copy link

CLAassistant commented Apr 9, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@per1234 per1234 per1234 requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AbhishekGS-MW @MCUdude @CLAassistant @per1234