Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Visual tweaks to Github's Remote Selector & No Remote views #1927

Merged
merged 10 commits into from
Jan 31, 2019
Merged

Visual tweaks to Github's Remote Selector & No Remote views #1927

merged 10 commits into from
Jan 31, 2019

Conversation

robertrossmann
Copy link
Contributor

Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • Suggestion: You can use checklists to keep track of progress for the sections on metrics, tests, documentation, and user research.

Description of the Change

This PR attempts to visually improve some of the less used views in the Github pane, namely:

  • NoRemotes view - shown when Github pane cannot detect any git remotes for the current workspace
  • RemoteSelector view - shown when there are multiple remotes configured for the current workspace

The overall idea behind all of these improvements was to make it as much consistent as possible with the Git tab's "Initialise git repository" view from the Git tab. Overall, the following changes have been made:

  • UI elements' text selection has been disabled and the cursor is now forced to the classic pointer
  • Content is now moved vertically to the centre of the pane
  • Buttons are now stretched to the full pane's width
  • All margins and paddings match those used in the Git tab's "initialise git repository" view
  • ⚠️ A git icon has been added to these views

    I would rather see a nice octocat icon there since the views are related to Github but I posses neither skills nor tools to craft such a vector graphic πŸ€·β€β™‚οΈ

Screenshot/Gif

Baseline

The goal of this PR is to make the other views look more like this one.

baseline

Before

multiple remotes - before changes

buttons disappearing

no repo - before changes

After

multiple remotes - after changes

buttons are resized

no repo - after changes

Alternate Designs

N/A

Benefits

Visually more pleasant experience when these views appear. 🎨

Possible Drawbacks

πŸ€·β€β™‚οΈ

Applicable Issues

Could not find any.

Metrics

N/A

Tests

Documentation

N/A

Release Notes

N/A

User Experience Research (Optional)

N/A

@robertrossmann robertrossmann changed the title Feat/visual tweaks Visual tweaks to Github's Remote Selector & No Remote views Jan 30, 2019
@vanessayuenn
Copy link
Contributor

Thanks for opening this PR @robertrossmann! πŸŽ‰ I think it's a great improvement on the remotes view. CC-ing @simurai for design πŸ‘€, maybe he will have input on which icon to use also:

⚠️ A git icon has been added to these views
I would rather see a nice octocat icon there since the views are related to Github but I possess neither skills nor tools to craft such a vector graphic πŸ€·β€β™‚οΈ

@annthurium
Copy link

thanks @robertrossmann ! Excited to have more visually appealing empty states, since we know those have been a bit neglected.

@simurai
Copy link
Contributor

simurai commented Jan 31, 2019

⚠️ A git icon has been added to these views
I would rather see a nice octocat icon there since the views are related to Github but I posses neither skills nor tools to craft such a vector graphic πŸ€·β€β™‚οΈ

Luckily, the Octicons include a :octocat: logo. I added it with 92ed316.

screen shot 2019-01-31 at 11 29 59 am
screen shot 2019-01-31 at 11 44 13 am

Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codecov seems down, otherwise, I think this is good to merge. πŸ‘ Thanks @robertrossmann πŸ™‡

@robertrossmann
Copy link
Contributor Author

Thanks @simurai for updating the icon! πŸ‘

I do have some follow-up improvements in mind after I gave it some more thought during my sleep (πŸ˜‡), but I guess it would be best to merge this and I'll open up another PR, because those changes would be a bigger departure from current designs of these screens and you just might not like it πŸ˜„.

Thanks, looking forward to having this merged in! ❀️

@smashwilson
Copy link
Contributor

codecov seems down

Weird. I think CodeCov having trouble with this PR because it's coming from a fork?

Copy link
Contributor

@smashwilson smashwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘ ✨

@smashwilson smashwilson merged commit a1af5c1 into atom:master Jan 31, 2019
@robertrossmann robertrossmann deleted the feat/visual-tweaks branch January 31, 2019 13:12
@kuychaco kuychaco mentioned this pull request Feb 5, 2019
18 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants