-
Notifications
You must be signed in to change notification settings - Fork 404
Visual tweaks to Github's Remote Selector & No Remote views #1927
Conversation
This disables the possibility to select UI elements' text on the Github tab. It mirrors the behaviour of the Git tab (see _styles/git-tab.less_).
The @font-size variable was not defined because the _variables.less_ stylesheet was not imported. I updated the sizes to match those defined in _git-tab.less_ for consistency.
Thanks for opening this PR @robertrossmann! π I think it's a great improvement on the remotes view. CC-ing @simurai for design π, maybe he will have input on which icon to use also:
|
thanks @robertrossmann ! Excited to have more visually appealing empty states, since we know those have been a bit neglected. |
Luckily, the Octicons include a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codecov seems down, otherwise, I think this is good to merge. π Thanks @robertrossmann π
Thanks @simurai for updating the icon! π I do have some follow-up improvements in mind after I gave it some more thought during my sleep (π), but I guess it would be best to merge this and I'll open up another PR, because those changes would be a bigger departure from current designs of these screens and you just might not like it π. Thanks, looking forward to having this merged in! β€οΈ |
Weird. I think CodeCov having trouble with this PR because it's coming from a fork? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π β¨
Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.
Requirements
Description of the Change
This PR attempts to visually improve some of the less used views in the Github pane, namely:
The overall idea behind all of these improvements was to make it as much consistent as possible with the Git tab's "Initialise git repository" view from the Git tab. Overall, the following changes have been made:
Screenshot/Gif
Baseline
Before
After
Alternate Designs
N/A
Benefits
Visually more pleasant experience when these views appear. π¨
Possible Drawbacks
π€·ββοΈ
Applicable Issues
Could not find any.
Metrics
N/A
Tests
Documentation
N/A
Release Notes
N/A
User Experience Research (Optional)
N/A