Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added support for "include_totals" to all_organization_member_roles #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jpayton-cx
Copy link

@jpayton-cx jpayton-cx commented Dec 17, 2024

Changes

Please describe both what is changing and why this is important. Include:

  • the get-org-member-roles is supposed to support an include_totals query param in addition to page and per_page, but the SDK does not expose it. Added support for the include_totals parameter to the all_organization_member_roles function in the Organizations class as outlined by the API documentation.

References

Please include relevant links supporting this change such as a:

Documentation for the get-organization-member-roles endpoint: https://auth0.com/docs/api/management/v2/organizations/get-organization-member-roles

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage
  • This change adds integration test coverage NA
  • This change has been tested on the latest version of the platform/language or why not
    Tested using python 3.13

Tested locally on my machine and modified unit tests to reflect the changes. Verified that all tests pass with the updated code. also verified that the include_totals parameter is actually supported by the API

Checklist

@jpayton-cx jpayton-cx requested a review from a team as a code owner December 17, 2024 00:57
Copy link
Contributor

@kishore7snehil kishore7snehil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kishore7snehil
Copy link
Contributor

Closing this as all the changes have been included in #660.
Thanks for the contribution!

kishore7snehil added a commit that referenced this pull request Jan 29, 2025
### Changes
#### **Community Raised PRs**
This PR contains the following community raised PRs :

- [fix typo in
docstring](#637)
- [Added support for "include_totals" to
all_organization_member_roles](#635)
- [Fixed Version Table](#633)
- [Remove upper bounds on all python dependency
versions](#628)
- [Adding secrets to Codecov Action
Upload](#624)

 #### **Dependabot PRs**
List of bumped up dependancy versions : 
- [pyopenssl](#658)
- [pyyaml](#657)
- [frozenlist](#656)
- [argcomplete](#655)
- [cffi](#654)


### Testing
- [x] **This change adds test coverage.**  
- [x] **This change has been tested on the latest version of the
platform/language**.

### Contributor Checklist
- [x] I agree to adhere to the [Auth0 General Contribution
Guidelines](https://github.com/auth0/open-source-template/blob/master/GENERAL-CONTRIBUTING.md).
- [x] I agree to uphold the [Auth0 Code of
Conduct](https://github.com/auth0/open-source-template/blob/master/CODE-OF-CONDUCT.md).
@jpayton-cx
Copy link
Author

Closing this as all the changes have been included in #660. Thanks for the contribution!

Thanks for approving @kishore7snehil !

nzetzl pushed a commit to nzetzl/auth0-python-nzetzl-fork that referenced this pull request Feb 25, 2025
### Changes
#### **Community Raised PRs**
This PR contains the following community raised PRs :

- [fix typo in
docstring](auth0#637)
- [Added support for "include_totals" to
all_organization_member_roles](auth0#635)
- [Fixed Version Table](auth0#633)
- [Remove upper bounds on all python dependency
versions](auth0#628)
- [Adding secrets to Codecov Action
Upload](auth0#624)

 #### **Dependabot PRs**
List of bumped up dependancy versions : 
- [pyopenssl](auth0#658)
- [pyyaml](auth0#657)
- [frozenlist](auth0#656)
- [argcomplete](auth0#655)
- [cffi](auth0#654)


### Testing
- [x] **This change adds test coverage.**  
- [x] **This change has been tested on the latest version of the
platform/language**.

### Contributor Checklist
- [x] I agree to adhere to the [Auth0 General Contribution
Guidelines](https://github.com/auth0/open-source-template/blob/master/GENERAL-CONTRIBUTING.md).
- [x] I agree to uphold the [Auth0 Code of
Conduct](https://github.com/auth0/open-source-template/blob/master/CODE-OF-CONDUCT.md).
nzetzl pushed a commit to nzetzl/auth0-python-nzetzl-fork that referenced this pull request Apr 2, 2025
### Changes
#### **Community Raised PRs**
This PR contains the following community raised PRs :

- [fix typo in
docstring](auth0#637)
- [Added support for "include_totals" to
all_organization_member_roles](auth0#635)
- [Fixed Version Table](auth0#633)
- [Remove upper bounds on all python dependency
versions](auth0#628)
- [Adding secrets to Codecov Action
Upload](auth0#624)

 #### **Dependabot PRs**
List of bumped up dependancy versions : 
- [pyopenssl](auth0#658)
- [pyyaml](auth0#657)
- [frozenlist](auth0#656)
- [argcomplete](auth0#655)
- [cffi](auth0#654)


### Testing
- [x] **This change adds test coverage.**  
- [x] **This change has been tested on the latest version of the
platform/language**.

### Contributor Checklist
- [x] I agree to adhere to the [Auth0 General Contribution
Guidelines](https://github.com/auth0/open-source-template/blob/master/GENERAL-CONTRIBUTING.md).
- [x] I agree to uphold the [Auth0 Code of
Conduct](https://github.com/auth0/open-source-template/blob/master/CODE-OF-CONDUCT.md).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants