-
Notifications
You must be signed in to change notification settings - Fork 174
Added support for "include_totals" to all_organization_member_roles #635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
jpayton-cx
wants to merge
2
commits into
auth0:master
from
jpayton-cx:support-include-totals-for-user-org-roles
Closed
Added support for "include_totals" to all_organization_member_roles #635
jpayton-cx
wants to merge
2
commits into
auth0:master
from
jpayton-cx:support-include-totals-for-user-org-roles
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kishore7snehil
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
4 tasks
Closing this as all the changes have been included in #660. |
kishore7snehil
added a commit
that referenced
this pull request
Jan 29, 2025
### Changes #### **Community Raised PRs** This PR contains the following community raised PRs : - [fix typo in docstring](#637) - [Added support for "include_totals" to all_organization_member_roles](#635) - [Fixed Version Table](#633) - [Remove upper bounds on all python dependency versions](#628) - [Adding secrets to Codecov Action Upload](#624) #### **Dependabot PRs** List of bumped up dependancy versions : - [pyopenssl](#658) - [pyyaml](#657) - [frozenlist](#656) - [argcomplete](#655) - [cffi](#654) ### Testing - [x] **This change adds test coverage.** - [x] **This change has been tested on the latest version of the platform/language**. ### Contributor Checklist - [x] I agree to adhere to the [Auth0 General Contribution Guidelines](https://github.com/auth0/open-source-template/blob/master/GENERAL-CONTRIBUTING.md). - [x] I agree to uphold the [Auth0 Code of Conduct](https://github.com/auth0/open-source-template/blob/master/CODE-OF-CONDUCT.md).
Thanks for approving @kishore7snehil ! |
nzetzl
pushed a commit
to nzetzl/auth0-python-nzetzl-fork
that referenced
this pull request
Feb 25, 2025
### Changes #### **Community Raised PRs** This PR contains the following community raised PRs : - [fix typo in docstring](auth0#637) - [Added support for "include_totals" to all_organization_member_roles](auth0#635) - [Fixed Version Table](auth0#633) - [Remove upper bounds on all python dependency versions](auth0#628) - [Adding secrets to Codecov Action Upload](auth0#624) #### **Dependabot PRs** List of bumped up dependancy versions : - [pyopenssl](auth0#658) - [pyyaml](auth0#657) - [frozenlist](auth0#656) - [argcomplete](auth0#655) - [cffi](auth0#654) ### Testing - [x] **This change adds test coverage.** - [x] **This change has been tested on the latest version of the platform/language**. ### Contributor Checklist - [x] I agree to adhere to the [Auth0 General Contribution Guidelines](https://github.com/auth0/open-source-template/blob/master/GENERAL-CONTRIBUTING.md). - [x] I agree to uphold the [Auth0 Code of Conduct](https://github.com/auth0/open-source-template/blob/master/CODE-OF-CONDUCT.md).
nzetzl
pushed a commit
to nzetzl/auth0-python-nzetzl-fork
that referenced
this pull request
Apr 2, 2025
### Changes #### **Community Raised PRs** This PR contains the following community raised PRs : - [fix typo in docstring](auth0#637) - [Added support for "include_totals" to all_organization_member_roles](auth0#635) - [Fixed Version Table](auth0#633) - [Remove upper bounds on all python dependency versions](auth0#628) - [Adding secrets to Codecov Action Upload](auth0#624) #### **Dependabot PRs** List of bumped up dependancy versions : - [pyopenssl](auth0#658) - [pyyaml](auth0#657) - [frozenlist](auth0#656) - [argcomplete](auth0#655) - [cffi](auth0#654) ### Testing - [x] **This change adds test coverage.** - [x] **This change has been tested on the latest version of the platform/language**. ### Contributor Checklist - [x] I agree to adhere to the [Auth0 General Contribution Guidelines](https://github.com/auth0/open-source-template/blob/master/GENERAL-CONTRIBUTING.md). - [x] I agree to uphold the [Auth0 Code of Conduct](https://github.com/auth0/open-source-template/blob/master/CODE-OF-CONDUCT.md).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Please describe both what is changing and why this is important. Include:
include_totals
query param in addition topage
andper_page
, but the SDK does not expose it. Added support for theinclude_totals
parameter to theall_organization_member_roles
function in the Organizations class as outlined by the API documentation.References
Please include relevant links supporting this change such as a:
Documentation for the get-organization-member-roles endpoint: https://auth0.com/docs/api/management/v2/organizations/get-organization-member-roles
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
This change adds integration test coverageNATested using python 3.13
Tested locally on my machine and modified unit tests to reflect the changes. Verified that all tests pass with the updated code. also verified that the include_totals parameter is actually supported by the API
Checklist