Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: Add MPL and hierarchy keyring example #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 147 commits into from
Apr 23, 2024
Merged

feat: Add MPL and hierarchy keyring example #634

merged 147 commits into from
Apr 23, 2024

Conversation

lucasmcdonald3
Copy link
Contributor

@lucasmcdonald3 lucasmcdonald3 commented Feb 2, 2024 •
edited
Loading

Issue #, if available:

Description of changes:

  • Add MPL support to ESDK-Python. This is an optional dependency that is only supported on Python 3.11+.
  • Create an example using the MPL's hierarchical keyring. This is mirrored from ESDK-Java.
  • Update CI:
    • No change to coverage for Python <3.11
    • Python 3.11+ now runs 3 test suites
      • Native ESDK tests WITHOUT the MPL installed in the environment
      • Native ESDK tests WITH the MPL installed in the environment
      • Native ESDK tests AND MPL-specific tests WITH the MPL installed in the environment

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@lucasmcdonald3 lucasmcdonald3 changed the title feat!: Add MPL and keyrings feat: Add MPL and hierarchy kering example Feb 2, 2024
@lucasmcdonald3 lucasmcdonald3 changed the title feat: Add MPL and hierarchy kering example feat: Add MPL and hierarchy keyring example Feb 2, 2024
@lucasmcdonald3 lucasmcdonald3 marked this pull request as ready for review February 26, 2024 22:37
@lucasmcdonald3 lucasmcdonald3 requested a review from a team as a code owner February 26, 2024 22:37
seebees
seebees requested changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@seebees seebees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good!
Going over the testing is the thing. I would like to go over the test vector plans.

seebees
seebees requested changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@seebees seebees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to deal with Encryption Context on decrypt and the required encryption context CMM.

seebees
seebees reviewed Apr 17, 2024
View reviewed changes
src/aws_encryption_sdk/materials_managers/mpl/materials.py
return int(mpl_algorithm_id, 16)


class EncryptionMaterialsFromMPL(Native_EncryptionMaterials):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about required EC and the like?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll plan to leave all required EC "stuff" in #645

ajewellamz
ajewellamz approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@ajewellamz ajewellamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

seebees
seebees approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@seebees seebees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like everything I cared about is now in #645.

@lucasmcdonald3 lucasmcdonald3 merged commit ac79bc8 into mpl-reviewed Apr 23, 2024
151 checks passed
@lucasmcdonald3 lucasmcdonald3 deleted the lucmcdon/mpl branch April 23, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@texastony texastony texastony left review comments

@seebees seebees seebees approved these changes

@ajewellamz ajewellamz ajewellamz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lucasmcdonald3 @seebees @texastony @ajewellamz @josecorella