Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: Required encryption context CMM #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 173 commits into from
Apr 26, 2024
Merged

feat: Required encryption context CMM #645

merged 173 commits into from
Apr 26, 2024

Conversation

lucasmcdonald3
Copy link
Contributor

@lucasmcdonald3 lucasmcdonald3 commented Feb 29, 2024 •
edited
Loading

Issue #, if available:

Description of changes:

  • Support required encryption context CMM
  • Add example using required encryption context CMM

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@lucasmcdonald3 lucasmcdonald3 marked this pull request as ready for review March 26, 2024 23:41
@lucasmcdonald3 lucasmcdonald3 requested a review from a team as a code owner March 26, 2024 23:41
seebees
seebees requested changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@seebees seebees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default CMM, or really any CMM should be able to handle reproduced EC. We may need to re-think how we want to expose the Default CMM in this new world.

@lucasmcdonald3 lucasmcdonald3 mentioned this pull request Apr 17, 2024
Merged
1 task
@lucasmcdonald3 lucasmcdonald3 mentioned this pull request Apr 19, 2024
Merged
1 task
ajewellamz
ajewellamz reviewed Apr 22, 2024
View reviewed changes
examples/src/keyrings/hierarchical_keyring.py
@@ -25,6 +55,7 @@

from .example_branch_key_id_supplier import ExampleBranchKeyIdSupplier

# TODO-MPL: Remove this as part of removing PYTHONPATH hacks.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this TODO is not yet TO BE DONE?

Copy link
Contributor Author

@lucasmcdonald3 lucasmcdonald3 Apr 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still TODO. I have to:

  • Update Dafny compiler to support outer-module
  • Update Smithy-Dafny to reference outer-module
  • Update MPL to use outer-module

I'm tracking that work separately.

ajewellamz
ajewellamz approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@ajewellamz ajewellamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from lucmcdon/mpl to mpl-reviewed April 23, 2024 16:12
seebees
seebees approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@seebees seebees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucasmcdonald3 lucasmcdonald3 merged commit 44d9192 into mpl-reviewed Apr 26, 2024
151 checks passed
@lucasmcdonald3 lucasmcdonald3 deleted the lucmcdon/mpl-requiredec branch April 26, 2024 17:47
@lucasmcdonald3 lucasmcdonald3 mentioned this pull request May 8, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seebees seebees seebees approved these changes

@ajewellamz ajewellamz ajewellamz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucasmcdonald3 @seebees @ajewellamz