Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Supporting status as query parameter#836

Closed
leog wants to merge 1 commit into
badges:masterfrom
leog:master
Closed

Supporting status as query parameter#836
leog wants to merge 1 commit into
badges:masterfrom
leog:master

Conversation

@leog

@leog leog commented Dec 7, 2016

Copy link
Copy Markdown

Adding a status parameter to override the right-hand-side text of a badge.
This implements feature request on #835

@espadrine

Copy link
Copy Markdown
Member

Thanks for your patch!

Query parameters are meant to have an effect on all badges; they mustn't be badge-type-dependent.

@leog

leog commented Dec 8, 2016

Copy link
Copy Markdown
Author

@espadrine Gotcha. I though it made sense to include it just on the general badge in order to avoid customizing the other badges which could potentially defeat the whole purpose of having them in the first place. Seemed like the general badge was general enough to include it there alone.

Taking into account my situation described on #835, should I try to work on applying it to the other badges as well?

Thanks a lot in advance.

@leog

leog commented Dec 22, 2016

Copy link
Copy Markdown
Author

@espadrine would appreciate a response on this to manage other options, although seems like a perfectly good feature to customize better a badge

@leog leog closed this Jan 5, 2017
@leog

leog commented Jan 8, 2017

Copy link
Copy Markdown
Author

Closing in favor of direct implementation presented on #852 rather than this workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants