Thanks to visit codestin.com
Credit goes to github.com

Skip to content

GitHub Standards integration + linkable templates#852

Closed
leog wants to merge 6 commits into
badges:masterfrom
leog:master
Closed

GitHub Standards integration + linkable templates#852
leog wants to merge 6 commits into
badges:masterfrom
leog:master

Conversation

@leog

@leog leog commented Jan 8, 2017

Copy link
Copy Markdown

This corresponds to the planned GitHub Standards badges discussed here standards/meta#1

For more information about GitHub Standards, please visit https://github.com/standards/meta

@leog

leog commented Jan 10, 2017

Copy link
Copy Markdown
Author

PTAL @espadrine

@leog leog mentioned this pull request Mar 4, 2017
@leog

leog commented Mar 5, 2017

Copy link
Copy Markdown
Author

any word on this @espadrine? launching @standards now, would be great to have this.

@paulmelnikow paulmelnikow added frontend The Docusaurus app serving the docs site service-badge New or updated service badge labels Mar 27, 2017
@paulmelnikow

Copy link
Copy Markdown
Member

Hi @leog, thanks for this contribution. I recently joined this project, and would like to find a way to accommodate yours.

This is a significant change, so it's going to take me a little while to digest. Wanted to let you know it was received!

@paulmelnikow

Copy link
Copy Markdown
Member

Possibly related: #598

@paulmelnikow paulmelnikow added core Server, BaseService, GitHub auth, Shared helpers and removed frontend The Docusaurus app serving the docs site labels Oct 12, 2017
@paulmelnikow

paulmelnikow commented Oct 13, 2017

Copy link
Copy Markdown
Member

#598 has been closed in favor of #1079, to discuss linking in templates.

@paulmelnikow

Copy link
Copy Markdown
Member

@leog Would you be up for pulling the badge change into a new branch and adding a test? I'd like to get that merged.

@RedSparr0w, you've been doing a lot of work on the templates, and you're much more knowledgeable about how the badges behave in different browsers. Would you be up for taking a look at the linking part of this in relation to the discussions in #1079 and #598?

@leog

leog commented Oct 14, 2017

Copy link
Copy Markdown
Author

@paulmelnikow sure, I can do that, and hopefully, then you can consider merging this PR which I need to modify to remove the linkable stuff 👍

@paulmelnikow

Copy link
Copy Markdown
Member

Sure, if you'd prefer to update this one that is totally fine! Would like to get it merged.

Thanks for your patience btw! This project is complicated and had quite a learning curve. 😉

And yes, it looks like linkable templates will be taken care of in #1172.

@paulmelnikow paulmelnikow removed the core Server, BaseService, GitHub auth, Shared helpers label Oct 14, 2017
@leog

leog commented Oct 14, 2017

Copy link
Copy Markdown
Author

@paulmelnikow oh ok, so I I'll need to wait for that PR to use that implementation of linkable templates.

Thank you for taking care of the project and already making progress on resolving issues. Count on me to help with anything 👍

@paulmelnikow

Copy link
Copy Markdown
Member

#1172 is merged!

@paulmelnikow

Copy link
Copy Markdown
Member

Hey, just wanted to follow up! Are you up for updating this PR (or opening a new one)?

@paulmelnikow

Copy link
Copy Markdown
Member

Hey @leog, wanna just reopen this when you're ready?

@paulmelnikow paulmelnikow added the on-hold Deferred in favor of another approach, blocked on preceding efforts, stale, or abandoned label Nov 3, 2017
@leog

leog commented Nov 3, 2017

Copy link
Copy Markdown
Author

Sorry @paulmelnikow, I've been swamped. Will do, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

on-hold Deferred in favor of another approach, blocked on preceding efforts, stale, or abandoned service-badge New or updated service badge

Development

Successfully merging this pull request may close these issues.

2 participants