GitHub Standards integration + linkable templates#852
Conversation
|
PTAL @espadrine |
|
any word on this @espadrine? launching @standards now, would be great to have this. |
|
Hi @leog, thanks for this contribution. I recently joined this project, and would like to find a way to accommodate yours. This is a significant change, so it's going to take me a little while to digest. Wanted to let you know it was received! |
|
Possibly related: #598 |
|
@leog Would you be up for pulling the badge change into a new branch and adding a test? I'd like to get that merged. @RedSparr0w, you've been doing a lot of work on the templates, and you're much more knowledgeable about how the badges behave in different browsers. Would you be up for taking a look at the linking part of this in relation to the discussions in #1079 and #598? |
|
@paulmelnikow sure, I can do that, and hopefully, then you can consider merging this PR which I need to modify to remove the linkable stuff 👍 |
|
Sure, if you'd prefer to update this one that is totally fine! Would like to get it merged. Thanks for your patience btw! This project is complicated and had quite a learning curve. 😉 And yes, it looks like linkable templates will be taken care of in #1172. |
|
@paulmelnikow oh ok, so I I'll need to wait for that PR to use that implementation of linkable templates. Thank you for taking care of the project and already making progress on resolving issues. Count on me to help with anything 👍 |
|
#1172 is merged! |
|
Hey, just wanted to follow up! Are you up for updating this PR (or opening a new one)? |
|
Hey @leog, wanna just reopen this when you're ready? |
|
Sorry @paulmelnikow, I've been swamped. Will do, thanks. |
This corresponds to the planned GitHub Standards badges discussed here standards/meta#1
For more information about GitHub Standards, please visit https://github.com/standards/meta