Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Implements post-process lens distortion effects#23110

Open
Breakdown-Dog wants to merge 6 commits intobevyengine:mainfrom
Breakdown-Dog:lens_distortion
Open

Implements post-process lens distortion effects#23110
Breakdown-Dog wants to merge 6 commits intobevyengine:mainfrom
Breakdown-Dog:lens_distortion

Conversation

@Breakdown-Dog
Copy link
Contributor

@Breakdown-Dog Breakdown-Dog commented Feb 22, 2026

Objective

  • Implements post-process lens distortion effects based on EffectStackPlugin.

Solution

  • This PR's implementation is based on a simplified special case of the Brown-Conrady model, where p₁ = p₂ = 0 and control is retained only for k₁ and k₂.
  • Additionally, supports controlling the degree of distortion in the horizontal and vertical directions based on the direction vector.

Testing

  • These effect components can work independently.
  • The example works as expected.
  • CI

Showcase

  • Barrel distortion
tu
  • Pincushion distortion
ao
  • Pincushion distortion with no distortion on the x-axis.
ao_no_x
  • With all effects.
cur

@github-actions
Copy link
Contributor

github-actions bot commented Feb 22, 2026

Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke!
You can review it at https://pixel-eagle.com/project/B04F67C0-C054-4A6F-92EC-F599FEC2FD1D?filter=PR-23110

If it's expected, please add the M-Deliberate-Rendering-Change label.

If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it.

@Breakdown-Dog
Copy link
Contributor Author

Breakdown-Dog commented Feb 22, 2026

I'm sorry, I didn't see any graphic changes in this link. Is that a bot mistake, or am I missing something? And the post_processing example works properly on my computer.

@alice-i-cecile alice-i-cecile added C-Feature A new feature, making something new possible A-Rendering Drawing game state to the screen D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Feb 22, 2026
@alice-i-cecile alice-i-cecile added the M-Release-Note Work that should be called out in the blog due to impact label Feb 22, 2026
@github-project-automation github-project-automation bot moved this to Needs SME Triage in Rendering Feb 22, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 22, 2026

It looks like your PR has been selected for a highlight in the next release blog post, but you didn't provide a release note.

Please review the instructions for writing release notes, then expand or revise the content in the release notes directory to showcase your changes.

@alice-i-cecile
Copy link
Member

alice-i-cecile commented Feb 22, 2026

I'm sorry, I didn't see any graphic changes in this link. Is that a bot mistake, or am I missing something? And the post_processing example works properly on my computer.

This has been flaky on main lately; I don't expect this is your fault.

@mate-h mate-h self-requested a review February 23, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mate-h mate-h Awaiting requested review from mate-h

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes M-Release-Note Work that should be called out in the blog due to impact S-Needs-Review Needs reviewer attention (from anyone!) to move forward

Projects

Rendering
Status: Needs SME Triage

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Breakdown-Dog @alice-i-cecile