feat(ecs): add CommandCondition trait for conditional mutations#23154
Open
ramon-bernardo wants to merge 2 commits intobevyengine:mainfrom
Open
feat(ecs): add CommandCondition trait for conditional mutations#23154ramon-bernardo wants to merge 2 commits intobevyengine:mainfrom
ramon-bernardo wants to merge 2 commits intobevyengine:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
CommandConditiontrait to enable fluent conditional entity mutations.insertorremovebased on boolean states or lazy evaluation.Solution
CommandConditionTrait: Created a new trait defining theevaluate(self) -> boolmethod. Takingselfby value allows closures to capture and move data from their environment flexibly.bool(direct evaluation) andFnOnce() -> bool(lazy evaluation via closures).EntityCommandsExtension: Added utility methods that leverage this trait:insert_if: Inserts a bundle only if the condition is true.insert_if_new_and: Inserts a bundle (preserving existing components) under a condition.remove_if: Removes a bundle under a condition.try_insert_if: A silenced version of conditional insertion for entities that might have been despawned.Testing
trueand skipped whenfalse.move ||) work as expected due to theselfownership model.cargo checkand.cargo testCommandCondition; it was designed to be consumed on evaluation to support the broadest range of closure captures.Showcase
This PR adds a new public API to make system code more declarative and readable.
Click to view usage examples