Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Sean / DMT5 signal trading page #1213

Merged
merged 10 commits into from Dec 4, 2020
Merged

Sean / DMT5 signal trading page #1213

merged 10 commits into from Dec 4, 2020

Conversation

ghost
Copy link

@ghost ghost commented Nov 19, 2020

Description

Summary

Changes:

  • Added new DMT5 signal trading page
  • Added optional notice prop for side tab component

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@vercel
Copy link

vercel bot commented Nov 19, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/deriv/deriv-com/j60wglcag/binary.sx
✅ Preview: https://deriv-com-git-sean-mt5-signal-trading.binary.sx

@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2020

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 62
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 92
🟢 PWA 100

Lighthouse ran on https://deriv-com-git-sean-mt5-signal-trading.binary.sx/

@suthesank
Copy link
Contributor

seems to have a conflict

@ghost ghost changed the base branch from master to crowdin November 19, 2020 07:19
Copy link
Contributor

@mustofa-binary mustofa-binary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please help to rebase this

@virtualpowwa virtualpowwa merged commit 64c8b06 into binary-com:crowdin Dec 4, 2020
mustofa-binary pushed a commit that referenced this pull request Dec 23, 2020
* feat: MT5 signal trading page [WIP]

* feat: MT5 signal trading page [WIP]

* DMT5 signal trading page & added notice prop for side tab components

* new mobile design changes

* new assets from design team

* refactoring active tab state to utilise hooks

* styling cleanup

* fix: design discrepencies

* fix: design discrepencies

* update copywriting
mustofa-binary added a commit that referenced this pull request Dec 23, 2020
* Kevin/fix:calculator-minor-issues (#1234)

* fix: qa comments

* fix:negative format fix

* fix:calculator

Co-authored-by: Kevin <[email protected]>

* Sean / DMT5 signal trading page (#1213)

* feat: MT5 signal trading page [WIP]

* feat: MT5 signal trading page [WIP]

* DMT5 signal trading page & added notice prop for side tab components

* new mobile design changes

* new assets from design team

* refactoring active tab state to utilise hooks

* styling cleanup

* fix: design discrepencies

* fix: design discrepencies

* update copywriting

* update eu footer (#1251)

* Kevin/feat: Market-Synth-multiplier add crash/boom, step index (#1209)

* feat: update minor styling and add crash/boom, step index

* fix: qa issues #1

* fix: suthesh commend, remove important

* fix: qa comments #2

* fix: crash boom alignment

* fix: qa comments

* fix: footer - add risk warning

* fix: remove risk warning

* redeploy: vercel

Co-authored-by: Kevin <[email protected]>
Co-authored-by: Kevin <[email protected]>

* translate:extract download

* translate: download

* translate: download

* translate:download

* fix: translation hotfix (#1281)

Co-authored-by: sean-binary <[email protected]>

* translate: extract, upload, download signal

* translate downlaod

* translate: download

* Kevin/hotfix calculator validation translation (#1290)

* fix:translate text

* fix:calculator-translation-validation-crowdin

* transate: upload

* translate: download

* fix: Localize component

* translate: download

* fix: truncated tabs for various languages (#1292)

Co-authored-by: sean-binary <[email protected]>

* added crash/boom in multipliers page (#1222)

* added crash/boom in multipliers page

* fix color

* fix layout

* translate: download

* fix: double side tab

* fix: conflict styled text

Co-authored-by: Kevin <[email protected]>
Co-authored-by: Kevin <[email protected]>
Co-authored-by: sean-binary <[email protected]>
Co-authored-by: Suthesan Kanagasabai <[email protected]>
Co-authored-by: Kevin <[email protected]>
Co-authored-by: Kevin <[email protected]>
Co-authored-by: mustofa-binary <[email protected]>
Co-authored-by: Sean Ho <[email protected]>
Co-authored-by: sean-binary <[email protected]>
Co-authored-by: sean-binary <[email protected]>
@ghost ghost deleted the sean/MT5-signal-trading branch December 31, 2020 07:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants