This repository was archived by the owner on May 20, 2025. It is now read-only.
Kevin/fix:calculator-minor-issues #1234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/deriv/deriv-com/ncyqn8qhc/binary.sx |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deriv-com-git-kevin-fix-calc-minor-diff.binary.sx/ |
mustofa-binary
approved these changes
Nov 26, 2020
d8323ce to
a856d4e
Compare
cd474cd to
bdf4832
Compare
mustofa-binary
approved these changes
Dec 3, 2020
mustofa-binary
pushed a commit
that referenced
this pull request
Dec 23, 2020
* fix: qa comments * fix:negative format fix * fix:calculator Co-authored-by: Kevin <[email protected]>
mustofa-binary
added a commit
that referenced
this pull request
Dec 23, 2020
* Kevin/fix:calculator-minor-issues (#1234) * fix: qa comments * fix:negative format fix * fix:calculator Co-authored-by: Kevin <[email protected]> * Sean / DMT5 signal trading page (#1213) * feat: MT5 signal trading page [WIP] * feat: MT5 signal trading page [WIP] * DMT5 signal trading page & added notice prop for side tab components * new mobile design changes * new assets from design team * refactoring active tab state to utilise hooks * styling cleanup * fix: design discrepencies * fix: design discrepencies * update copywriting * update eu footer (#1251) * Kevin/feat: Market-Synth-multiplier add crash/boom, step index (#1209) * feat: update minor styling and add crash/boom, step index * fix: qa issues #1 * fix: suthesh commend, remove important * fix: qa comments #2 * fix: crash boom alignment * fix: qa comments * fix: footer - add risk warning * fix: remove risk warning * redeploy: vercel Co-authored-by: Kevin <[email protected]> Co-authored-by: Kevin <[email protected]> * translate:extract download * translate: download * translate: download * translate:download * fix: translation hotfix (#1281) Co-authored-by: sean-binary <[email protected]> * translate: extract, upload, download signal * translate downlaod * translate: download * Kevin/hotfix calculator validation translation (#1290) * fix:translate text * fix:calculator-translation-validation-crowdin * transate: upload * translate: download * fix: Localize component * translate: download * fix: truncated tabs for various languages (#1292) Co-authored-by: sean-binary <[email protected]> * added crash/boom in multipliers page (#1222) * added crash/boom in multipliers page * fix color * fix layout * translate: download * fix: double side tab * fix: conflict styled text Co-authored-by: Kevin <[email protected]> Co-authored-by: Kevin <[email protected]> Co-authored-by: sean-binary <[email protected]> Co-authored-by: Suthesan Kanagasabai <[email protected]> Co-authored-by: Kevin <[email protected]> Co-authored-by: Kevin <[email protected]> Co-authored-by: mustofa-binary <[email protected]> Co-authored-by: Sean Ho <[email protected]> Co-authored-by: sean-binary <[email protected]> Co-authored-by: sean-binary <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix minor issues for calculator
Summary
Changes:
on localize
Type of change