This repository was archived by the owner on May 20, 2025. It is now read-only.
Kevin/update stock indices to stocks and indices on header, footer, and market #1826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/deriv/deriv-com/5niubin4Ms6DKHKeVvJwb2q2m4Fb |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deriv-com-git-fork-kevinw-binary-kevin-update-stock-and-indices.binary.sx/ |
njazuli-deriv
approved these changes
Jun 14, 2021
suthesank
approved these changes
Jun 16, 2021
suthesank
reviewed
Jun 16, 2021
src/pages/home/_hero.js
Outdated
| @@ -114,8 +114,8 @@ const ImageWrapper = styled(Box)` | |||
| const Hero = ({ is_ppc }) => { | |||
| const data = useStaticQuery(query) | |||
| const typewriter_text = !is_ppc | |||
| ? localize('Trade forex, commodities, synthetic and stock indices') | |||
| : localize('Trade forex, commodities, and stock indices') | |||
| ? localize('Trade forex, commodities, synthetic and stocks & indices') | |||
There was a problem hiding this comment.
I have a feeling something needs to be changed here 😅 Shouldn't it be synthetic indices and stocks & indices?
There was a problem hiding this comment.
Discussed this with lipika and it should be Trade forex, commodities, synthetics, and stocks & indices instead
ghost
approved these changes
Jun 18, 2021
suthesank
approved these changes
Jun 21, 2021
njazuli-deriv
pushed a commit
to njazuli-deriv/deriv-com
that referenced
this pull request
Jul 22, 2021
…nd market (binary-com#1826) * update stock indices to stocks and indices on header, footer, and market * add dev comments
njazuli-deriv
pushed a commit
to njazuli-deriv/deriv-com
that referenced
this pull request
Jul 22, 2021
…nd market (binary-com#1826) * update stock indices to stocks and indices on header, footer, and market * add dev comments
suthesank
added a commit
that referenced
this pull request
Aug 23, 2021
* Kevin/update stock indices to stocks and indices on header, footer, and market (#1826) * update stock indices to stocks and indices on header, footer, and market * add dev comments * Nuri/Feat : Deriv x seo changes (#1875) * p added seo for Deriv X pages * added back h2 to what is deriv x text * Suthesh/add-jump-indices (#1856) * added new metals, energy and jump indices * minimised svg * fiona / Change margin to CFDs (#1841) * add markets available for CFD trading * add start trading CFDs on deriv section * add styling for cfd page sections * add more CFDs page sections * add cfd page * change margin to cfd * update margin to cfds * minify svg file * fix: missing s and currencies * triger deployment * trigger deployment * update margin-calculator link * fix: spacing on title * align checklist icon with titles in responsive mode * remove real Deriv X * update text * remove extra space * change margin and swap calculator * implement pr changes * delete fragment * add redirect to cfds page * redirect margin to cfds * add markets available for CFD trading * add start trading CFDs on deriv section * add styling for cfd page sections * add more CFDs page sections * add cfd page * change margin to cfd * update margin to cfds * minify svg file * fix: missing s and currencies * update margin-calculator link * fix: spacing on title * align checklist icon with titles in responsive mode * remove real Deriv X * update text * remove extra space * change margin and swap calculator * implement pr changes * delete fragment * add redirect to cfds page * redirect margin to cfds * remove unused import * delete margin folder Co-authored-by: fiona-deriv <[email protected]> * Amina/Footer update (#1910) * pass_variables_to_footer_text * messages.json-extract * Revert "messages.json-extract" This reverts commit 1bb1e61. revert messages.json * suthesh/update-translations-crowdin (#1911) * added new strings for translations * added strings from Amina's PR * downloaded latest translations (incomplete) * Mahdiyeh/Fix: compare_accounts_content_for_eu_conuntries (#1888) * fix compare mt5 accounts content for eu and non_eu clients * fix typo * Al-amin/35136/Deriv p2p landing page update (#1906) * updating Deriv P2P landing page * added Deriv P2P articles on Help centre * address PR comment * addressed QA comments * handle youtube video mobile view * updated P2P numbers card * updated the iframe mobile view * addressed PR comment * nikolai.berestevich/text/update numbers on story page (#1917) Co-authored-by: Nikolai Berestevich <[email protected]> * change sentences (#1916) * added comma and updated crowdin platform (#1983) * replace bet with speculate (#1977) * enable derivx cfd in non eu country (#1970) * Kevin/DMT5 Signal change text content (#1951) * change text content * fix typo * Revert "Kevin/DMT5 Signal change text content (#1951)" (#1989) This reverts commit d30b025. * update hyperlink with second branch (#1941) * Revert "update hyperlink with second branch (#1941)" (#1991) This reverts commit f7c542f. * downloaded latest translations (#1999) * Suthesh/update crowdin hotfix (#2002) * extracted and uploaded * downloaded latest translations * removed space (#2006) * downloaded latest translations (#2012) * Suthesh/crowdin hotfix text (#2020) * edited text, extracted and uploaded * updated ach * downloaded latest translations Co-authored-by: Suthesan <[email protected]> Co-authored-by: Kevin <[email protected]> Co-authored-by: njazuli-deriv <[email protected]> Co-authored-by: fiona-deriv <[email protected]> Co-authored-by: fiona-deriv <[email protected]> Co-authored-by: amina-deriv <[email protected]> Co-authored-by: mahdiyeh-fs <[email protected]> Co-authored-by: Al-amin Abdulkareem <[email protected]> Co-authored-by: Nikolai Berestevich <[email protected]> Co-authored-by: Nikolai Berestevich <[email protected]> Co-authored-by: Habib Binary <[email protected]> Co-authored-by: behnaz-fs <[email protected]> Co-authored-by: Suthesan <[email protected]>
suthesank
pushed a commit
to suthesank/deriv-com
that referenced
this pull request
Aug 25, 2021
…nd market (binary-com#1826) * update stock indices to stocks and indices on header, footer, and market * add dev comments
khalid-deriv
pushed a commit
to khalid-deriv/deriv-com
that referenced
this pull request
Dec 28, 2021
* Kevin/update stock indices to stocks and indices on header, footer, and market (binary-com#1826) * update stock indices to stocks and indices on header, footer, and market * add dev comments * Nuri/Feat : Deriv x seo changes (binary-com#1875) * p added seo for Deriv X pages * added back h2 to what is deriv x text * Suthesh/add-jump-indices (binary-com#1856) * added new metals, energy and jump indices * minimised svg * fiona / Change margin to CFDs (binary-com#1841) * add markets available for CFD trading * add start trading CFDs on deriv section * add styling for cfd page sections * add more CFDs page sections * add cfd page * change margin to cfd * update margin to cfds * minify svg file * fix: missing s and currencies * triger deployment * trigger deployment * update margin-calculator link * fix: spacing on title * align checklist icon with titles in responsive mode * remove real Deriv X * update text * remove extra space * change margin and swap calculator * implement pr changes * delete fragment * add redirect to cfds page * redirect margin to cfds * add markets available for CFD trading * add start trading CFDs on deriv section * add styling for cfd page sections * add more CFDs page sections * add cfd page * change margin to cfd * update margin to cfds * minify svg file * fix: missing s and currencies * update margin-calculator link * fix: spacing on title * align checklist icon with titles in responsive mode * remove real Deriv X * update text * remove extra space * change margin and swap calculator * implement pr changes * delete fragment * add redirect to cfds page * redirect margin to cfds * remove unused import * delete margin folder Co-authored-by: fiona-deriv <[email protected]> * Amina/Footer update (binary-com#1910) * pass_variables_to_footer_text * messages.json-extract * Revert "messages.json-extract" This reverts commit 1bb1e61. revert messages.json * suthesh/update-translations-crowdin (binary-com#1911) * added new strings for translations * added strings from Amina's PR * downloaded latest translations (incomplete) * Mahdiyeh/Fix: compare_accounts_content_for_eu_conuntries (binary-com#1888) * fix compare mt5 accounts content for eu and non_eu clients * fix typo * Al-amin/35136/Deriv p2p landing page update (binary-com#1906) * updating Deriv P2P landing page * added Deriv P2P articles on Help centre * address PR comment * addressed QA comments * handle youtube video mobile view * updated P2P numbers card * updated the iframe mobile view * addressed PR comment * nikolai.berestevich/text/update numbers on story page (binary-com#1917) Co-authored-by: Nikolai Berestevich <[email protected]> * change sentences (binary-com#1916) * added comma and updated crowdin platform (binary-com#1983) * replace bet with speculate (binary-com#1977) * enable derivx cfd in non eu country (binary-com#1970) * Kevin/DMT5 Signal change text content (binary-com#1951) * change text content * fix typo * Revert "Kevin/DMT5 Signal change text content (binary-com#1951)" (binary-com#1989) This reverts commit d30b025. * update hyperlink with second branch (binary-com#1941) * Revert "update hyperlink with second branch (binary-com#1941)" (binary-com#1991) This reverts commit f7c542f. * downloaded latest translations (binary-com#1999) * Suthesh/update crowdin hotfix (binary-com#2002) * extracted and uploaded * downloaded latest translations * removed space (binary-com#2006) * downloaded latest translations (binary-com#2012) * Suthesh/crowdin hotfix text (binary-com#2020) * edited text, extracted and uploaded * updated ach * downloaded latest translations Co-authored-by: Suthesan <[email protected]> Co-authored-by: Kevin <[email protected]> Co-authored-by: njazuli-deriv <[email protected]> Co-authored-by: fiona-deriv <[email protected]> Co-authored-by: fiona-deriv <[email protected]> Co-authored-by: amina-deriv <[email protected]> Co-authored-by: mahdiyeh-fs <[email protected]> Co-authored-by: Al-amin Abdulkareem <[email protected]> Co-authored-by: Nikolai Berestevich <[email protected]> Co-authored-by: Nikolai Berestevich <[email protected]> Co-authored-by: Habib Binary <[email protected]> Co-authored-by: behnaz-fs <[email protected]> Co-authored-by: Suthesan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Type of change