Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Split off a blockdev internal crate#1050

Merged
HuijingHei merged 1 commit into
bootc-dev:mainfrom
cgwalters:blockdev-crate
Jan 23, 2025
Merged

Split off a blockdev internal crate#1050
HuijingHei merged 1 commit into
bootc-dev:mainfrom
cgwalters:blockdev-crate

Conversation

@cgwalters

Copy link
Copy Markdown
Collaborator

This code has been forked between bootupd and coreos-installer and here. This is prep for having bootupd pull it from bootc's git so we can deduplicate.

This code has been forked between bootupd and coreos-installer
and here. This is prep for having bootupd pull it from bootc's
git so we can deduplicate.

Signed-off-by: Colin Walters <[email protected]>
@github-actions github-actions Bot added the area/install Issues related to `bootc install` label Jan 22, 2025

@HuijingHei HuijingHei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HuijingHei

Copy link
Copy Markdown
Contributor

One small question, should we use bootc-blockdev like coreos/bootupd#821 ?

@HuijingHei HuijingHei merged commit 9a58693 into bootc-dev:main Jan 23, 2025
@cgwalters

Copy link
Copy Markdown
Collaborator Author

One small question, should we use bootc-blockdev like coreos/bootupd#821 ?

We do when importing it elsewhere, but yeah it would likely make sense to rename all of the internal crates to have a bootc- prefix.

HuijingHei added a commit to HuijingHei/bootupd that referenced this pull request Jan 24, 2025
HuijingHei added a commit to HuijingHei/bootupd that referenced this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/install Issues related to `bootc install`

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants