Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use bootc-utils for command helpers#821

Merged
HuijingHei merged 1 commit into
coreos:mainfrom
cgwalters:use-bootc-utils
Jan 21, 2025
Merged

Use bootc-utils for command helpers#821
HuijingHei merged 1 commit into
coreos:mainfrom
cgwalters:use-bootc-utils

Conversation

@cgwalters

Copy link
Copy Markdown
Member

This enables more code sharing. I didn't do a full port here, but this starts the ball rolling. In particular I think run_and_parse_json() is nice and elegant.

This enables more code sharing. I didn't do a full port
here, but this starts the ball rolling. In particular
I think `run_and_parse_json()` is nice and elegant.

@HuijingHei HuijingHei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, so fast.

@HuijingHei

HuijingHei commented Jan 21, 2025

Copy link
Copy Markdown
Contributor

Maybe in future, also refactor the CommandRunExt into a separate internal crate and publish? Before that, agree it is the fastest way to use it.

@HuijingHei HuijingHei merged commit efe41b6 into coreos:main Jan 21, 2025
@travier

travier commented Jan 21, 2025

Copy link
Copy Markdown
Member

Are we planning to publish this as an independent crate on crates.io? Otherwise I can see this causing problem with packaging in Fedora unless we vendor things which we don't do generally.

@cgwalters

Copy link
Copy Markdown
Member Author

Are we planning to publish this as an independent crate on crates.io?

Maybe.

Otherwise I can see this causing problem with packaging in Fedora unless we vendor things which we don't do generally.

Some projects for sure do, I think as you know I personally disagree with the approach for about 60% of the Fedora Rust packaging. And bootupd does vendor consistently across both Fedora+RHEL right now: https://src.fedoraproject.org/rpms/rust-bootupd/blob/rawhide/f/rust-bootupd.spec#_13

@travier

travier commented Jan 22, 2025

Copy link
Copy Markdown
Member

I disagree as well with the no-vendoring approach. I hadn't checked that we already vendor the code so that should not be an issue. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants