Upgrade requirements September 2022#7064
Merged
Merged
Conversation
The upgrade causes several auth related errors in functional tests
* docutils pinnned at 0.17 because sphinx-rtd-theme doesn't support a bigger version
* pytest-factoryboy pinnned at 2.4.0 because on 2.5.0 we get:
File "/home/adria/dev/pyenvs/ckan-py3/src/ckan/ckan/tests/pytest_ckan/fixtures.py", line 98, in <module>
register(factories.Sysadmin, "sysadmin")
File "/home/adria/dev/pyenvs/ckan-py3/lib/python3.8/site-packages/pytest_factoryboy/fixture.py", line 124, in register
assert model_name != factory_name, (
AssertionError: Naming collision for <Sysadmin for <class 'ckan.model.user.User'>>:
* factory fixture name: sysadmin
* model fixture name: sysadmin
Please provide different name for model fixture.
assert 'sysadmin' != 'sysadmin'
SQLAlchemy 1.4.2 mixed model.Package and model.PackageExtra as both have a state column
lxml is a requirement of feedgen, currently unmaintained. Mako is a requirement of alembic, which has its version unpinned
Member
|
Great @amercader ! Thanks for this, looks great and it's good to have CKAN running on latest versions! 🚀 I'm gonna take a look at Flask-Login issue once it's merged to avoid noise in the PR. |
This was referenced Sep 14, 2022
Contributor
|
hey @amercader @pdelboca I've tested a bit the new I m not sure why we have this behavior, but I will keep digging, and see if I can fix something. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ITranslation(see Flask-Babel 2.0.0 breaks ITranslation #6708 and Add support for multiple domains python-babel/flask-babel#194 cc @TkTech )