Revert Flask requirement back to 2.0.3#7082
Merged
amercader merged 2 commits intoSep 14, 2022
Merged
Conversation
Member
|
This is annoying, sorry about the Looks like we need to upgrade Flask-login to 0.6.2 to support Flask 2.2.x, but apart from the auth failures mentioned in #7064 looks like also there are also failures in Flask-multistatic, which doesn't look like it's maintained. We better revisit this after 2.10 is released. Can you create an issue with the details @pdelboca ? Also no need to add a changelog file for changes within the same version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an mistake made when merging #7064
Proposed Fixes
Even when the PR with updated requirements works (#7064) the
requirements.inandrequirements.txtfile are not sync. (executingpip-compilereturns a differentrequirements.txtfile).This is causing
masterto work withrequirements.txtbut it will fail when compiling a new one. Looks like b685d64 added the requirement, but never compiled.I'm creating this PR to revert Flask requirements to
2.0.3since running CKAN with2.2.2does not work.