Codestin Search App

williammartin · 2026-04-21T15:24:36Z

Description

Removes the env var that gates telemetry, so it will be on by default.

See https://cli.github.com/telemetry for everything around this.

Copilot

Pull request overview

This PR removes the GH_PRIVATE_ENABLE_TELEMETRY environment variable gate so telemetry behavior is controlled by existing telemetry configuration (and still disabled for likely GHES users), and updates acceptance fixtures accordingly.

Changes:

Remove GH_PRIVATE_ENABLE_TELEMETRY gating from CLI startup telemetry initialization.
Update telemetry-related acceptance .txtar fixtures to stop setting GH_PRIVATE_ENABLE_TELEMETRY.
Keep GHES-user detection as a hard disable for telemetry.

Show a summary per file

File	Description
internal/ghcmd/cmd.go	Removes the `GH_PRIVATE_ENABLE_TELEMETRY` check so telemetry can be enabled via existing config/env (`GH_TELEMETRY`) without the private flag.
acceptance/testdata/telemetry/telemetry-for-official-extension-stub.txtar	Drops now-unnecessary `GH_PRIVATE_ENABLE_TELEMETRY` env setup.
acceptance/testdata/telemetry/telemetry-failure-does-not-break-command.txtar	Drops now-unnecessary `GH_PRIVATE_ENABLE_TELEMETRY` env setup.
acceptance/testdata/telemetry/no-telemetry-for-send-telemetry.txtar	Drops now-unnecessary `GH_PRIVATE_ENABLE_TELEMETRY` env setup.
acceptance/testdata/telemetry/no-telemetry-for-ghes-user.txtar	Drops now-unnecessary `GH_PRIVATE_ENABLE_TELEMETRY` env setup.
acceptance/testdata/telemetry/no-telemetry-for-extension.txtar	Drops now-unnecessary `GH_PRIVATE_ENABLE_TELEMETRY` env setup.
acceptance/testdata/telemetry/no-telemetry-for-completion.txtar	Drops now-unnecessary `GH_PRIVATE_ENABLE_TELEMETRY` env setup.
acceptance/testdata/telemetry/no-telemetry-for-alias.txtar	Drops now-unnecessary `GH_PRIVATE_ENABLE_TELEMETRY` env setup.
acceptance/testdata/telemetry/command-invocation.txtar	Drops now-unnecessary `GH_PRIVATE_ENABLE_TELEMETRY` env setup.
acceptance/testdata/skills/skills-preview.txtar	Drops now-unnecessary `GH_PRIVATE_ENABLE_TELEMETRY` env setup for skill telemetry fixture.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 10/10 changed files
Comments generated: 1

Crefix · 2026-04-22T12:47:58Z

Mate, you're based on NL and with a leadership position... How dare to betray your EU peers? No way this is legal (nor required) 😪

NeckBeardPrince · 2026-04-22T12:49:44Z

The enshittification continues.

bhargavkulk · 2026-04-22T17:57:05Z

Why are these things done without any community input? Such telemetry options should always be opt-in and not opt-out. Very scummy behavior.

NeckBeardPrince · 2026-04-22T18:03:59Z

Why are these things done without any community input? Such telemetry options should always be opt-in and not opt-out. Very scummy behavior.

Micro$oft

mrt181 · 2026-04-23T05:30:06Z

Why are these things done without any community input? Such telemetry options should always be opt-in and not opt-out. Very scummy behavior.

Micro$oft

You mean Microslop

Wren6991 · 2026-04-24T16:38:29Z

 		telemetryService = &telemetry.NoOpService{}
 	default:
 		telemetryState := telemetry.ParseTelemetryState(cfg.Telemetry().Value)
-		telemetryDisabled := os.Getenv("GH_PRIVATE_ENABLE_TELEMETRY") == "" || mightBeGHESUser(cfg)


Hi, I have a minor code review nit: What the hell is this?

There isn't even an opt-out. Please add a note to the changelog saying "we scrape your data unconditionally now" so users can make an informed decision.

If you could understand the code you are reading, you would realise that the telemetryState variable is fed from ParseTelemetryState()

cli/internal/telemetry/telemetry.go

Line 106 in ea7a245

func ParseTelemetryState(configValue string) TelemetryState {

and that is the user can opt out as stated in the documentation with the GH_TELEMETRY, the DO_NOT_TRACK environnement variable or event with the gh config set telemetry disabled CLI config.

These configs will make the functions return Disabled for the telemetryState variable and &telemetry.NoOpService{} (a dummy, empty, or placeholder service) will be used.

That's not scraping.

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [cli/cli](https://github.com/cli/cli) | minor | `v2.90.0` → `v2.92.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>cli/cli (cli/cli)</summary> ### [`v2.92.0`](https://github.com/cli/cli/releases/tag/v2.92.0): GitHub CLI 2.92.0 [Compare Source](cli/cli@v2.91.0...v2.92.0) #### Support GitHub Enterprise Cloud (GHEC) in `skill` commandset Now `gh skill` subcommands (`install`, `preview`, `publish`, `search`, `update`) are able to work with [GHEC](https://docs.github.com/en/enterprise-cloud@latest/admin/overview/about-github-enterprise-cloud) hosts with data residency. #### Add `--allow-hidden-dirs` flag to `skill preview` Following the addition of `--allow-hidden-dirs` to `skill install` in the previous release, now the flag is also supported in `skill preview`, allowing users to preview skills located in hidden (dot-prefixed) directories such as `.claude/skills/`, `.agents/skills/`, and `.github/skills/`. #### What's Changed ##### ✨ Features - feat(skills): add --allow-hidden-dirs flag to preview command by [@SamMorrowDrums](https://github.com/SamMorrowDrums) in [#13265](cli/cli#13265) - feat(skills): support GHEC with data residency hosts by [@SamMorrowDrums](https://github.com/SamMorrowDrums) in [#13264](cli/cli#13264) ##### 🐛 Fixes - Fix SetSampleRate not updating sample\_rate dimension by [@williammartin](https://github.com/williammartin) in [#13259](cli/cli#13259) - Fix log terminal injection by [@williammartin](https://github.com/williammartin) in [#13272](cli/cli#13272) - Add "Resource not accessible" to ProjectsV2IgnorableError by [@maxbeizer](https://github.com/maxbeizer) in [#13281](cli/cli#13281) ##### 📚 Docs & Chores - fix: using variable interpolation \`${{ in deployment.yml... by [@orbisai0security](https://github.com/orbisai0security) in [#13258](cli/cli#13258) - docs: correct typo in Linux Homebrew copy by [@cassidyjames](https://github.com/cassidyjames) in [#13273](cli/cli#13273) - Install skills flat by Name, not namespaced InstallName by [@SamMorrowDrums](https://github.com/SamMorrowDrums) in [#13266](cli/cli#13266) - chore: fix zsh completion on debian by [@babakks](https://github.com/babakks) in [#13274](cli/cli#13274) - Add trust disclaimer to extension help text by [@travellertales](https://github.com/travellertales) in [#13296](cli/cli#13296) - Bump Go to 1.26.2 by [@github-actions](https://github.com/github-actions)\[bot] in [#13301](cli/cli#13301) #####

Dependencies - chore(deps): bump github.com/mattn/go-isatty from 0.0.20 to 0.0.21 by [@dependabot](https://github.com/dependabot)\[bot] in [#13161](cli/cli#13161) - chore(deps): bump github.com/google/go-containerregistry from 0.21.4 to 0.21.5 by [@dependabot](https://github.com/dependabot)\[bot] in [#13162](cli/cli#13162) - chore(deps): bump charm.land/lipgloss/v2 from 2.0.2 to 2.0.3 by [@dependabot](https://github.com/dependabot)\[bot] in [#13163](cli/cli#13163) - chore(deps): bump charm.land/bubbletea/v2 from 2.0.2 to 2.0.6 by [@dependabot](https://github.com/dependabot)\[bot] in [#13206](cli/cli#13206) - chore(deps): bump github.com/gdamore/tcell/v2 from 2.13.8 to 2.13.9 by [@dependabot](https://github.com/dependabot)\[bot] in [#13241](cli/cli#13241) - chore(deps): bump github.com/mattn/go-isatty from 0.0.21 to 0.0.22 by [@dependabot](https://github.com/dependabot)\[bot] in [#13298](cli/cli#13298) #### New Contributors - [@orbisai0security](https://github.com/orbisai0security) made their first contribution in [#13258](cli/cli#13258) - [@cassidyjames](https://github.com/cassidyjames) made their first contribution in [#13273](cli/cli#13273) - [@travellertales](https://github.com/travellertales) made their first contribution in [#13296](cli/cli#13296) **Full Changelog**: <cli/cli@v2.91.0...v2.92.0> ### [`v2.91.0`](https://github.com/cli/cli/releases/tag/v2.91.0): GitHub CLI 2.91.0 [Compare Source](cli/cli@v2.90.0...v2.91.0) #### GitHub CLI now collects pseudonymous telemetry To better understand how features are used in practice, especially as agentic adoption grows, GitHub CLI now sends pseudonymous telemetry. See [Telemetry](https://cli.github.com/telemetry) for more details on what's collected, why, and how to opt out. #### Support more agents in `gh skill` Thanks to community feedback, `gh` now supports a large number of agent hosts. Run `gh skill install --help` for the list of available agents. #### Improve skill discovery `gh skill install` now adds the `--allow-hidden-dirs` flag to support discovering skills in hidden (dot-prefixed) directories such as `.claude/skills/`, `.agents/skills/`, and `.github/skills/`. #### Detect skills re-published from other sources GitHut CLI now detects if the skill to be installed is re-published from an upstream source and offers the option to install it from there. The `--upstream` flag is also added for non-interactive use cases. #### What's Changed ##### ✨ Features - Add support for installation in multiple agent hosts in `gh skills install` by [@tommaso-moro](https://github.com/tommaso-moro) in [#13209](cli/cli#13209) - Add --allow-hidden-dirs flag to gh skill install by [@SamMorrowDrums](https://github.com/SamMorrowDrums) in [#13213](cli/cli#13213) - Make skill discovery less strict: support nested `skills/` directories by [@SamMorrowDrums](https://github.com/SamMorrowDrums) in [#13235](cli/cli#13235) - feat(skills): detect re-published skills and offer upstream install by [@SamMorrowDrums](https://github.com/SamMorrowDrums) in [#13236](cli/cli#13236) ##### 🐛 Fixes - Fix `skills publish --fix` to not publish by [@SamMorrowDrums](https://github.com/SamMorrowDrums) in [#13237](cli/cli#13237) - fix(skills): match skills by install name in preview command by [@SamMorrowDrums](https://github.com/SamMorrowDrums) in [#13249](cli/cli#13249) ##### 📚 Docs & Chores - Remove misleading text by [@tommaso-moro](https://github.com/tommaso-moro) in [#13203](cli/cli#13203) - Add sampled command telemetry by [@williammartin](https://github.com/williammartin) in [#13191](cli/cli#13191) - Do not send telemetry for aliases by [@williammartin](https://github.com/williammartin) in [#13192](cli/cli#13192) - Add skills specific telemetry by [@williammartin](https://github.com/williammartin) in [#13204](cli/cli#13204) - Record CI context in telemetry by [@williammartin](https://github.com/williammartin) in [#13210](cli/cli#13210) - Record official extension telemetry by [@williammartin](https://github.com/williammartin) in [#13205](cli/cli#13205) - Add telemetry command by [@williammartin](https://github.com/williammartin) in [#13253](cli/cli#13253) - Log when there is no telemetry by [@williammartin](https://github.com/williammartin) in [#13255](cli/cli#13255) - docs(skills): add gh and gh-skill agent skills by [@BagToad](https://github.com/BagToad) in [#13244](cli/cli#13244) - Enable telemetry without env var by [@williammartin](https://github.com/williammartin) in [#13254](cli/cli#13254) **Full Changelog**: <cli/cli@v2.90.0...v2.91.0> </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).

This is mostly defaults, sadly necessary as gh has enabled opt-out telemetry which is unethical. See: https://docs.github.com/en/github-cli/github-cli/github-cli-telemetry See: cli/cli#13254

williammartin requested a review from a team as a code owner April 21, 2026 15:24

williammartin requested review from BagToad, babakks and Copilot April 21, 2026 15:24

Copilot started reviewing on behalf of williammartin April 21, 2026 15:25 View session

Copilot AI reviewed Apr 21, 2026

View reviewed changes

Comment thread acceptance/testdata/skills/skills-preview.txtar

babakks approved these changes Apr 21, 2026

View reviewed changes

williammartin force-pushed the wm/enable-telemetry branch from 3c4ee9c to 9778a80 Compare April 21, 2026 16:00

babakks approved these changes Apr 21, 2026

View reviewed changes

babakks mentioned this pull request Apr 21, 2026

Log when there is no telemetry #13255

Merged

Enable telemetry without env var

90ef03e

babakks force-pushed the wm/enable-telemetry branch from 9778a80 to 90ef03e Compare April 21, 2026 17:41

This comment was marked as spam.

Sign in to view

williammartin merged commit 6fffc2e into trunk Apr 22, 2026
11 checks passed

williammartin deleted the wm/enable-telemetry branch April 22, 2026 10:16

Wren6991 reviewed Apr 24, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable telemetry without env var#13254

Enable telemetry without env var#13254
williammartin merged 1 commit into
trunkfrom
wm/enable-telemetry

williammartin commented Apr 21, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Uh oh!

Crefix commented Apr 22, 2026 •

edited

Loading

Uh oh!

NeckBeardPrince commented Apr 22, 2026

Uh oh!

bhargavkulk commented Apr 22, 2026

Uh oh!

NeckBeardPrince commented Apr 22, 2026

Uh oh!

mrt181 commented Apr 23, 2026

Uh oh!

Wren6991 Apr 24, 2026

Uh oh!

RickyNotaro Apr 24, 2026 •

edited

Loading

Uh oh!

nukeop Apr 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Conversation

williammartin commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Uh oh!

Crefix commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NeckBeardPrince commented Apr 22, 2026

Uh oh!

bhargavkulk commented Apr 22, 2026

Uh oh!

NeckBeardPrince commented Apr 22, 2026

Uh oh!

mrt181 commented Apr 23, 2026

Uh oh!

Wren6991 Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

RickyNotaro Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nukeop Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

williammartin commented Apr 21, 2026 •

edited

Loading

Crefix commented Apr 22, 2026 •

edited

Loading

RickyNotaro Apr 24, 2026 •

edited

Loading