fix(wrangler) remove putQueue call when deploying a worker with queue producer binding #10288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 08b57fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
petebacondarwin
approved these changes
Aug 8, 2025
19749c5 to
48e1a15
Compare
72e60cc to
a51eef1
Compare
Co-authored-by: Pete Bacon Darwin <[email protected]>
a51eef1 to
08b57fc
Compare
|
Congratulations @tgarg-cf, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cme7jii3v094807ie0h29ghyw This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Merged
petebacondarwin
added a commit
that referenced
this pull request
Aug 12, 2025
… producer binding (#10288) * MQ-861: Remove putQueue call when setting queue producer binding * remove calls to mockPutQueueById in tests * Update .changeset/chatty-pens-sniff.md Co-authored-by: Pete Bacon Darwin <[email protected]> * try to ensure that the required deploy workers job is not skipped * test: add a waitFor around log check for email bindings --------- Co-authored-by: Pete Bacon Darwin <[email protected]> Co-authored-by: Peter Bacon Darwin <[email protected]>
Merged
petebacondarwin
added a commit
that referenced
this pull request
Aug 14, 2025
… producer binding (#10288) (#10330) * MQ-861: Remove putQueue call when setting queue producer binding * remove calls to mockPutQueueById in tests * Update .changeset/chatty-pens-sniff.md * try to ensure that the required deploy workers job is not skipped * test: add a waitFor around log check for email bindings --------- Co-authored-by: tgarg-cf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #MQ-861
Removed a call to putQueue when deploying a worker with a queue producer binding.
This is needed because a worker should not be able to affect queue level settings. Additionally, when having multiple producers, the settings will be determined by the last deployed producer which also leads to issues.