Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Move the normalizeAndValidateConfig tests to the workers-utils package #11539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
petebacondarwin merged 1 commit into from
Dec 8, 2025
Merged

Move the normalizeAndValidateConfig tests to the workers-utils package #11539

petebacondarwin merged 1 commit into from
Dec 8, 2025

Conversation

@dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Dec 6, 2025

The normalizeAndValidateConfig utility is fully implemented in the workers-utils package, however its tests are in the wrangler package instead. So in this PR I am moving these to the workers-utils package instead.

  • Tests
    • Tests included/updated
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: tests change
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: workers-utils is not in V3

A picture of a cute animal (not mandatory, but encouraged)

@changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: f534e86

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Dec 6, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 6, 2025 •
edited
Loading

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11539

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11539

miniflare

npm i https://pkg.pr.new/miniflare@11539

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11539

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11539

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11539

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11539

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11539

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11539

wrangler

npm i https://pkg.pr.new/wrangler@11539

commit: f534e86

@dario-piotrowicz dario-piotrowicz force-pushed the dario/normalize-and-validate-config-tests-to-utils branch from c50b132 to cce5441 Compare December 6, 2025 23:06
@dario-piotrowicz dario-piotrowicz force-pushed the dario/normalize-and-validate-config-tests-to-utils branch from cce5441 to f534e86 Compare December 7, 2025 22:18
@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review December 8, 2025 10:29
@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner December 8, 2025 10:29
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Dec 8, 2025
@petebacondarwin petebacondarwin merged commit eb351cb into main Dec 8, 2025
35 of 40 checks passed
@petebacondarwin petebacondarwin deleted the dario/normalize-and-validate-config-tests-to-utils branch December 8, 2025 11:28
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Dec 8, 2025
@dario-piotrowicz dario-piotrowicz mentioned this pull request Dec 12, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petebacondarwin petebacondarwin petebacondarwin approved these changes

Assignees

No one assigned

Labels

no-changeset-required

Projects

workers-sdk
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dario-piotrowicz @petebacondarwin