move patchConfig tests from wrangler to workers-utils, also add wrangler-config testing utils to workers-utils/test-helpers
#11621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f01b3c6 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…ngler-config testing utils to workers-utils/test-helpers
836ac3f to
f01b3c6
Compare
vicb
approved these changes
Dec 15, 2025
Merged
AmirSa12
pushed a commit
to AmirSa12/workers-sdk
that referenced
this pull request
Jan 5, 2026
…ngler-config testing utils to workers-utils/test-helpers (cloudflare#11621)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
patchConfigutility is defined in theworkers-utilspackage but is tested in thewranglerpackage instead. I do believe that the tests should live in the same package implementing the utility so I am moving them here.Those tests require the
writeWranglerConfig,writeDeployRedirectConfig,writeRedirectedWranglerConfigandreadWranglerConfigtesting utilities so I am moving those under workers-utils/test-helpers.Note
This is the same sort of change as #11539.
Besides
patchConfig(as far as I can tell) there is only one more instance of a worker-utils utility being tested in wranglervalidatePagesConfigI'm happy to also move those tests but I wanted to keep thing simple/separate and just focus on thepatchConfigtests in this PRA picture of a cute animal (not mandatory, but encouraged)