Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

skepticfx
Copy link
Member

@skepticfx skepticfx commented Jun 12, 2025

  • Replace hardcoded Cloudflare registry domain with getCloudflareContainerRegistry helper
  • Introduce getCloudflareRegistryWithAccountNamespace helper for correct image tagging
  • Refactor tests and build scripts to use new registry helpers
  • Switch to knobs.ts file for getting the containerRegistry which also respects a global env var "CLOUDFLARE_CONTAINER_REGISTRY"

Fixes #CC-5408

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: Tests exist already for e2e
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: This is still private beta.
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: This is a new feature

@skepticfx skepticfx requested review from a team as code owners June 12, 2025 00:48
Copy link

changeset-bot bot commented Jun 12, 2025

🦋 Changeset detected

Latest commit: b0e5864

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Jun 12, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9564

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9564

miniflare

npm i https://pkg.pr.new/miniflare@9564

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9564

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9564

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9564

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9564

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9564

wrangler

npm i https://pkg.pr.new/wrangler@9564

commit: b0e5864

@skepticfx skepticfx added the skip-v3-pr Skip validation of presence of a v3 backport PR label Jun 12, 2025
@skepticfx skepticfx force-pushed the nafeez/registry-defaults branch from 96c8e22 to 637231c Compare June 12, 2025 03:30
@skepticfx skepticfx force-pushed the nafeez/registry-defaults branch from 637231c to 139138a Compare June 12, 2025 16:59
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jun 12, 2025
@skepticfx skepticfx force-pushed the nafeez/registry-defaults branch from 139138a to bd0fd5b Compare June 12, 2025 17:15
- Replace hardcoded Cloudflare registry domain with `getCloudflareContainerRegistry` helper
- Introduce `getCloudflareRegistryWithAccountNamespace` helper for correct image tagging
- Refactor tests and build scripts to use new registry helpers
- Switch to `knobs.ts` file for getting the containerRegistry which also respects
a global env var "CLOUDFLARE_CONTAINER_REGISTRY"
@skepticfx skepticfx force-pushed the nafeez/registry-defaults branch from bd0fd5b to b0e5864 Compare June 12, 2025 17:21
@skepticfx skepticfx added this pull request to the merge queue Jun 13, 2025
Merged via the queue into main with commit 1d3293f Jun 13, 2025
20 checks passed
@skepticfx skepticfx deleted the nafeez/registry-defaults branch June 13, 2025 01:11
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jun 13, 2025
jseba added a commit to jseba/workers-sdk that referenced this pull request Jun 14, 2025
* 'main' of ssh://github.com/cloudflare/workers-sdk: (213 commits)
  fix(vite-plugin-cloudflare): allow unknown entrypoint on startup (cloudflare#9583)
  add warning about env not specified to potentially risky wrangler commands (cloudflare#9344)
  test: correctly delete test d1 databases (cloudflare#9598)
  Add details to v3 maintenance worflow error message (cloudflare#9602)
  drop unused `WRANGLER_UNENV_RESOLVE_PATHS` env var (cloudflare#9593)
  warn instead of erroring if no exposed ports. and remove unused dev_exposed_ports (cloudflare#9573)
  fix(wrangler): point to the right doc location (replaces cloudflare#9353) (cloudflare#9592)
  [vitest-pool-worker] Add `type: module` in package.json (cloudflare#9595)
  Enable HTML handling for HTML files in the public directory (cloudflare#9548)
  switch from go container to js (cloudflare#9588)
  containers: switch to Cloudflare container registry (cloudflare#9564)
  performance improvement: restart a mixed mode session only if the worker's remote bindings have changed (cloudflare#9536)
  ci: delete more orphaned resources from e2e tests (cloudflare#9580)
  test: remove `verifyBuildScript` logic from c3 e2e tests (cloudflare#9504)
  fix(vite-plugin): ensure node compat globals are injected before any imports (cloudflare#9581)
  feat(containers-shared): Move `isDockerfile` utility function to `containers-shared` (cloudflare#9577)
  allow `startWorker` to accept `false` as an `inspector` option (to disable the inspector server) (cloudflare#9550)
  Update capnp generated code from the workerd.capnp (cloudflare#9582)
  Bump `@cloudflare/unenv-preset` to 2.3.3 (cloudflare#9566)
  test: make custom build bundling tests more robust (cloudflare#9494)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-v3-pr Skip validation of presence of a v3 backport PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants