fix(vite-plugin-cloudflare): allow unknown entrypoint on startup #9583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cb8211f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
jamesopstad
approved these changes
Jun 13, 2025
jamesopstad
reviewed
Jun 13, 2025
Added in cb8211f |
Merged
jseba
added a commit
to jseba/workers-sdk
that referenced
this pull request
Jun 14, 2025
* 'main' of ssh://github.com/cloudflare/workers-sdk: (213 commits) fix(vite-plugin-cloudflare): allow unknown entrypoint on startup (cloudflare#9583) add warning about env not specified to potentially risky wrangler commands (cloudflare#9344) test: correctly delete test d1 databases (cloudflare#9598) Add details to v3 maintenance worflow error message (cloudflare#9602) drop unused `WRANGLER_UNENV_RESOLVE_PATHS` env var (cloudflare#9593) warn instead of erroring if no exposed ports. and remove unused dev_exposed_ports (cloudflare#9573) fix(wrangler): point to the right doc location (replaces cloudflare#9353) (cloudflare#9592) [vitest-pool-worker] Add `type: module` in package.json (cloudflare#9595) Enable HTML handling for HTML files in the public directory (cloudflare#9548) switch from go container to js (cloudflare#9588) containers: switch to Cloudflare container registry (cloudflare#9564) performance improvement: restart a mixed mode session only if the worker's remote bindings have changed (cloudflare#9536) ci: delete more orphaned resources from e2e tests (cloudflare#9580) test: remove `verifyBuildScript` logic from c3 e2e tests (cloudflare#9504) fix(vite-plugin): ensure node compat globals are injected before any imports (cloudflare#9581) feat(containers-shared): Move `isDockerfile` utility function to `containers-shared` (cloudflare#9577) allow `startWorker` to accept `false` as an `inspector` option (to disable the inspector server) (cloudflare#9550) Update capnp generated code from the workerd.capnp (cloudflare#9582) Bump `@cloudflare/unenv-preset` to 2.3.3 (cloudflare#9566) test: make custom build bundling tests more robust (cloudflare#9494) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes n/a.
Now that we have Dev registry support, the vite plugin should not crash on startup if it sees a service binding to a named entrypoint from an unknown worker:
AssertionError [ERR_ASSERTION]: unknown-worker does not match a worker name. at getWorkerToWorkerEntrypointNamesMap (file:///Users/edmund/Workspace/workers-sdk/packages/vite-plugin-cloudflare/dist/index.js:13514:9) at getDevMiniflareOptions (file:///Users/edmund/Workspace/workers-sdk/packages/vite-plugin-cloudflare/dist/index.js:13769:44) at async configureServer (file:///Users/edmund/Workspace/workers-sdk/packages/vite-plugin-cloudflare/dist/index.js:14644:37) at async _createServer (file:///Users/edmund/Workspace/workers-sdk/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected]/node_modules/vite/dist/node/chunks/dep-CfG9u7Cn.js:44149:20) at async CAC.<anonymous> (file:///Users/edmund/Workspace/workers-sdk/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected]/node_modules/vite/dist/node/cli.js:750:20)The dev registry will return a runtime error instead if it couldn't resolve an address for the unknown worker.