-
Notifications
You must be signed in to change notification settings - Fork 991
fix(vite-plugin-cloudflare): allow unknown entrypoint on startup #9583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vite-plugin-cloudflare): allow unknown entrypoint on startup #9583
Conversation
🦋 Changeset detectedLatest commit: cb8211f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just approved but if you could add an unknown service binding to the wrangler.jsonc
in the worker
playground that would be good. That way we'll catch regressions of this behaviour.
Added in cb8211f |
* 'main' of ssh://github.com/cloudflare/workers-sdk: (213 commits) fix(vite-plugin-cloudflare): allow unknown entrypoint on startup (cloudflare#9583) add warning about env not specified to potentially risky wrangler commands (cloudflare#9344) test: correctly delete test d1 databases (cloudflare#9598) Add details to v3 maintenance worflow error message (cloudflare#9602) drop unused `WRANGLER_UNENV_RESOLVE_PATHS` env var (cloudflare#9593) warn instead of erroring if no exposed ports. and remove unused dev_exposed_ports (cloudflare#9573) fix(wrangler): point to the right doc location (replaces cloudflare#9353) (cloudflare#9592) [vitest-pool-worker] Add `type: module` in package.json (cloudflare#9595) Enable HTML handling for HTML files in the public directory (cloudflare#9548) switch from go container to js (cloudflare#9588) containers: switch to Cloudflare container registry (cloudflare#9564) performance improvement: restart a mixed mode session only if the worker's remote bindings have changed (cloudflare#9536) ci: delete more orphaned resources from e2e tests (cloudflare#9580) test: remove `verifyBuildScript` logic from c3 e2e tests (cloudflare#9504) fix(vite-plugin): ensure node compat globals are injected before any imports (cloudflare#9581) feat(containers-shared): Move `isDockerfile` utility function to `containers-shared` (cloudflare#9577) allow `startWorker` to accept `false` as an `inspector` option (to disable the inspector server) (cloudflare#9550) Update capnp generated code from the workerd.capnp (cloudflare#9582) Bump `@cloudflare/unenv-preset` to 2.3.3 (cloudflare#9566) test: make custom build bundling tests more robust (cloudflare#9494) ...
Fixes n/a.
Now that we have Dev registry support, the vite plugin should not crash on startup if it sees a service binding to a named entrypoint from an unknown worker:
The dev registry will return a runtime error instead if it couldn't resolve an address for the unknown worker.