[probes.external] Refactor the external probe code #695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manugarg
added a commit
that referenced
this pull request
May 21, 2024
We should not be writing to buffered stdout and stderr. This change was introduced recently in v0.13.4: github.com//pull/695
manugarg
added a commit
that referenced
this pull request
May 21, 2024
We should not be writing to buffered stdout and stderr. This change was introduced recently in v0.13.4: github.com//pull/695
stvnrhodes
added a commit
to stvnrhodes/cloudprober
that referenced
this pull request
Jun 18, 2024
I noticed that https://pkg.go.dev/github.com/cloudprober/cloudprober/probes/external/serverutils#ServeContext doesn't take a context. This has been true since it was added in cloudprober#695, so it looks like an oversight. This change updates the function to properly take a context (and to work with its example code.
manugarg
pushed a commit
that referenced
this pull request
Jun 19, 2024
I noticed that https://pkg.go.dev/github.com/cloudprober/cloudprober/probes/external/serverutils#ServeContext doesn't take a context. This has been true since it was added in #695, so it looks like an oversight. This change updates the function to properly take a context (and to work with its example code.
conallob
pushed a commit
to conallob/cloudprober
that referenced
this pull request
May 6, 2025
- Split out server handling code into a different file - Add tests for serverutils - Use context to cancel various loops (note: we'll still not be able to cancel the pending read).
conallob
pushed a commit
to conallob/cloudprober
that referenced
this pull request
May 6, 2025
We should not be writing to buffered stdout and stderr. This change was introduced recently in v0.13.4: github.com/cloudprober/pull/695
conallob
pushed a commit
to conallob/cloudprober
that referenced
this pull request
May 6, 2025
I noticed that https://pkg.go.dev/github.com/cloudprober/cloudprober/probes/external/serverutils#ServeContext doesn't take a context. This has been true since it was added in cloudprober#695, so it looks like an oversight. This change updates the function to properly take a context (and to work with its example code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
read.