feat: Pass installation ID from env to usage report #2106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
premium/usage.go
Outdated
Comment on lines
731
to
738
| func maybeGetInstallationID(tokenType auth.TokenType) string { | ||
| switch tokenType { | ||
| case auth.SyncRunAPIKey, auth.SyncTestConnectionAPIKey: | ||
| return os.Getenv("_CQ_INSTALLATION_ID") | ||
| default: | ||
| return "" | ||
| } | ||
| } |
There was a problem hiding this comment.
Could we not have a function with a name starting with maybe? :))
Since this is used in a single place either way, let's skip extracting it as a separate function; or just rename it :)).
There was a problem hiding this comment.
is determineInstallationID() ok? 771f100
murarustefaan
approved these changes
Mar 31, 2025
kodiakhq bot
pushed a commit
that referenced
this pull request
Apr 2, 2025
🤖 I have created a release *beep* *boop* --- ## [4.76.0](v4.75.0...v4.76.0) (2025-04-02) ### Features * Pass installation ID from env to usage report ([#2106](#2106)) ([0bea6e7](0bea6e7)) ### Bug Fixes * **deps:** Update golang.org/x/exp digest to 054e65f ([#2110](#2110)) ([f9875f8](f9875f8)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.26.9 ([#2112](#2112)) ([abd2117](abd2117)) * Error if both PKs and PK components are set ([#2113](#2113)) ([4f0b312](4f0b312)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
May 2, 2025
Follow-up to #2106 Plugins use regular team API keys for usage reports, not platform-specific local API keys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes with cloudquery/cloudquery#20455