Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

DavertMik
Copy link
Contributor

@DavertMik DavertMik commented Mar 29, 2020

Bringing all changes + adding documentation

@DavertMik
Copy link
Contributor Author

@gkushang Yes! I am writing release notes for shadow dom support right now

@pablopaul
Copy link
Collaborator

@DavertMik I merged #2302 into this branch, please add it to the changelog, thanks

@github-actions
Copy link

🌀 Tests overview by Testomatio

Found 946 mocha tests in 74 files

✔️ Added 3 tests

+ Playwright - Emulation: should open page as iPhone 
+ CodeceptJS commentStep plugin: should print nested steps when global var comments used
+ CodeceptJS commentStep plugin: should print nested steps when local var comments used

🗑️ Removed 11 tests

- Playwright: should not fail for localStorage.clear() on about:blank
- Playwright: open page : #amOnPage: should be unauthenticated 
- Playwright: #waitForClickable: should wait for clickable
- Playwright: #waitForClickable: should wait for clickable by XPath
- Playwright: #waitForClickable: should fail for disabled element
- Playwright: #waitForClickable: should fail for disabled element by XPath
- Playwright: #waitForClickable: should fail for element not in viewport by top
- Playwright: #waitForClickable: should fail for element not in viewport by bottom
- Playwright: #waitForClickable: should fail for element not in viewport by left
- Playwright: #waitForClickable: should fail for element not in viewport by right
- Playwright: #waitForClickable: should fail for overlapping element
⚠️ List all skipped tests (1)
📎 List all suites (62)

@DavertMik DavertMik merged commit 6cd7e7a into master Mar 31, 2020
@DavertMik DavertMik deleted the release-2.6 branch March 31, 2020 19:38
@DavertMik
Copy link
Contributor Author

Codacy Here is an overview of what got changed by this pull request:

Clones added
============
- lib/helper/WebDriver.js  22
- lib/helper/Puppeteer.js  1
- test/runner/comment_step_test.js  1
- test/helper/Playwright_test.js  1
- lib/helper/Playwright.js  1
         

See the complete overview on Codacy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants