Playwright fixes - Work in progress #2291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 29, 2020 14:47
|
@DavertMik hopefully this fixes some of the playwright tests |
|
Any other failures i suspect are things i missed that were broken in in the playwright 0.12.1 API changes |
|
Need some help with |
|
Thank you! |
DavertMik
added a commit
that referenced
this pull request
Mar 31, 2020
* updated docs & playwright guide * commentSteps plugin * minor tests fixes * Playwright fixes - Work in progress (#2291) * fix wait for value * fix waitForEnabled * fix add cookies Co-authored-by: George Griffiths <[email protected]> * fixed tests for playwright * fixed Playwright/Puppeteer tests * Fix run-workers issue in gherkin (#2293) * fixed allure test * updated changelog, fixed tests * fixed tests * fixed playwright setup, fixed worker tests * fixed WebDriver test * removed xvfb from playwright setup * added xvfb run to playwright setup * added one lib to playwright setup * Store --profile in process.env.profile instead of process.profile to make it available in workers. * fixed typo in basic within section readme (#2294) * Backward compatibility for using in process.profile. * Add fallback in test config. * Store --profile in process.env.profile also for run-rerun command. * fixed tests * updated changelog * updated documentation Co-authored-by: Mykhailo Bodnarchuk <mykhailo.bodnarchuk@surfer-172-29-3-81-hotspot.internet-for-guests.com> Co-authored-by: George Griffiths <[email protected]> Co-authored-by: George Griffiths <[email protected]> Co-authored-by: Koushik Mohan <[email protected]> Co-authored-by: Paul Vincent Beigang <[email protected]> Co-authored-by: Sharode <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
Applicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs)npm run lint)npm test)