Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Playwright fixes - Work in progress #2291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 29, 2020
Merged

Playwright fixes - Work in progress #2291

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ebec2f
fix wait for value
Mar 29, 2020
b2c8a4b
fix waitForEnabled
Mar 29, 2020
16c3277
fix add cookies
Mar 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix add cookies
  • Loading branch information
George Griffiths committed Mar 29, 2020
commit 16c32771fff4a273624bb97b6414b19379d6d670
4 changes: 2 additions & 2 deletions lib/helper/Playwright.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1327,9 +1327,9 @@ class Playwright extends Helper {
*/
async setCookie(cookie) {
if (Array.isArray(cookie)) {
return this.browserContext.setCookies(...cookie);
return this.browserContext.addCookies(...cookie);
}
return this.browserContext.setCookies([cookie]);
return this.browserContext.addCookies([cookie]);
}

/**
Expand Down
Empty file added settings_override.xml
View file
Open in desktop
Empty file.
2 changes: 1 addition & 1 deletion test/helper/Playwright_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ describe('Playwright', function () {
I = new Playwright({
url: siteUrl,
windowSize: '500x700',
show: true,
show: false,
waitForTimeout: 5000,
waitForAction: 500,
restart: true,
Expand Down