Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: update script to use quotes around dirname for better path handling #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2025
Merged

fix: update script to use quotes around dirname for better path handling #146

merged 1 commit into from
May 1, 2025

Conversation

andy1li
Copy link
Member

@andy1li andy1li commented May 1, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Bug Fixes
    • Improved script handling of file paths containing spaces or special characters, ensuring more robust execution across different environments.

@andy1li andy1li self-assigned this May 1, 2025
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented May 1, 2025 •
edited
Loading

Walkthrough

This change updates several shell scripts by modifying how they determine their own directory path. Specifically, it adds double quotes around the $0 variable in the dirname command, changing $(dirname $0) to $(dirname "$0"). This adjustment ensures that script paths containing spaces or special characters are handled correctly. No other logic, control flow, or public interfaces are altered in these scripts.

Changes

File(s) Change Summary
compiled_starters/cpp/.codecrafters/run.sh
compiled_starters/cpp/your_program.sh		 Updated dirname $0 to dirname "$0" to improve handling of paths with spaces or special characters.
solutions/cpp/01-gg4/code/.codecrafters/run.sh
solutions/cpp/01-gg4/code/your_program.sh		 Same update: added quotes around $0 in dirname for robust path handling.
starter_templates/cpp/code/.codecrafters/run.sh Same update: added quotes around $0 in dirname for robust path handling.

Possibly related PRs

Poem

In the warren of scripts, a bunny hopped by,
Quoting his paths so spaces won't lie.
With dirname "$0" he danced with delight,
No more tripping on spaces, his code running right.
🐇✨ Bashful bugs now hop away,
For quoted scripts are here to stay!

✨ Finishing Touches
  • 📝 Generate Docstrings
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed May 1, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (5)
compiled_starters/cpp/.codecrafters/run.sh (1)

11-11: Wrap the exec path in quotes to fully prevent word splitting
Quoting $0 inside dirname is a great improvement, but the resulting substitution $(dirname "$0")/build/git is still unquoted in the exec call. If the script lives in a directory with spaces, the path may be split into multiple arguments. Wrap the entire command substitution and the trailing /build/git in quotes:

-exec $(dirname "$0")/build/git "$@"
+exec "$(dirname "$0")/build/git" "$@"
🧰 Tools
🪛 Shellcheck (0.10.0)

[warning] 11-11: Quote this to prevent word splitting.

(SC2046)

solutions/cpp/01-gg4/code/your_program.sh (1)

25-25: Quote the substituted path in the exec invocation
You've correctly quoted $0 in dirname, but the expanded path remains unquoted when passed to exec. To handle directories with spaces, wrap it in quotes:

-exec $(dirname "$0")/build/git "$@"
+exec "$(dirname "$0")/build/git" "$@"
🧰 Tools
🪛 Shellcheck (0.10.0)

[warning] 25-25: Quote this to prevent word splitting.

(SC2046)

starter_templates/cpp/code/.codecrafters/run.sh (1)

11-11: Fully quote the exec argument to avoid splitting on spaces
While quoting $0 in dirname handles spaces in the script name, the composite path still needs quoting in the exec call. Apply:

-exec $(dirname "$0")/build/git "$@"
+exec "$(dirname "$0")/build/git" "$@"
🧰 Tools
🪛 Shellcheck (0.10.0)

[warning] 11-11: Quote this to prevent word splitting.

(SC2046)

solutions/cpp/01-gg4/code/.codecrafters/run.sh (1)

11-11: Ensure the command substitution is quoted in exec
To fully guard against word splitting, wrap the expanded path in quotes:

-exec $(dirname "$0")/build/git "$@"
+exec "$(dirname "$0")/build/git" "$@"
🧰 Tools
🪛 Shellcheck (0.10.0)

[warning] 11-11: Quote this to prevent word splitting.

(SC2046)

compiled_starters/cpp/your_program.sh (1)

25-25: Quote the resulting path in the exec call
The inner $0 is quoted for dirname, but the final path should also be quoted when passed to exec. Update to:

-exec $(dirname "$0")/build/git "$@"
+exec "$(dirname "$0")/build/git" "$@"
🧰 Tools
🪛 Shellcheck (0.10.0)

[warning] 25-25: Quote this to prevent word splitting.

(SC2046)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f2b4dad and 0276951.

📒 Files selected for processing (5)
  • compiled_starters/cpp/.codecrafters/run.sh (1 hunks)
  • compiled_starters/cpp/your_program.sh (1 hunks)
  • solutions/cpp/01-gg4/code/.codecrafters/run.sh (1 hunks)
  • solutions/cpp/01-gg4/code/your_program.sh (1 hunks)
  • starter_templates/cpp/code/.codecrafters/run.sh (1 hunks)
🧰 Additional context used
🪛 Shellcheck (0.10.0)
solutions/cpp/01-gg4/code/your_program.sh

[warning] 25-25: Quote this to prevent word splitting.

(SC2046)

starter_templates/cpp/code/.codecrafters/run.sh

[warning] 11-11: Quote this to prevent word splitting.

(SC2046)

solutions/cpp/01-gg4/code/.codecrafters/run.sh

[warning] 11-11: Quote this to prevent word splitting.

(SC2046)

compiled_starters/cpp/.codecrafters/run.sh

[warning] 11-11: Quote this to prevent word splitting.

(SC2046)

compiled_starters/cpp/your_program.sh

[warning] 25-25: Quote this to prevent word splitting.

(SC2046)

⏰ Context from checks skipped due to timeout of 90000ms (7)
  • GitHub Check: test_course_definition / test (zig)
  • GitHub Check: test_course_definition / test (kotlin)
  • GitHub Check: test_course_definition / test (java)
  • GitHub Check: test_course_definition / test (haskell)
  • GitHub Check: test_course_definition / test (go)
  • GitHub Check: test_course_definition / test (cpp)
  • GitHub Check: test_course_definition / test (c)

@andy1li andy1li merged commit d303a41 into main May 1, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

@andy1li andy1li

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andy1li