Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(coder plugin): update peer deps to match scaffolder #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2024
Merged

chore(coder plugin): update peer deps to match scaffolder #113

merged 1 commit into from
Apr 11, 2024

Conversation

Kira-Pilot
Copy link
Member

Closes #56

@Kira-Pilot Kira-Pilot requested a review from Parkreiner April 10, 2024 14:56
Parkreiner
Parkreiner approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this looks good.
Our own code has started using the useSyncExternalStore hook from React 18, but it's through an official shim/polyfill, so nothing should break for React 16/17

@Kira-Pilot Kira-Pilot merged commit e013e35 into main Apr 11, 2024
@Kira-Pilot Kira-Pilot deleted the update-peer-dep/kira-pilot branch April 11, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Parkreiner Parkreiner Parkreiner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kira-Pilot @Parkreiner