Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Parse git urls #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 14, 2024
Merged

Parse git urls #127

merged 4 commits into from
May 14, 2024

Conversation

code-asher
Copy link
Member

@code-asher code-asher commented May 13, 2024

Closes #117

As part of this, I moved the VS Code URI to an annotation during the processing phase.

I decided to go with a dependency over hand-rolling because there are quite a few forges that it supports and it did not seem worthwhile to figure all that out again if someone has already done it, and the code looks reasonable to me although I do still think a go-chi style of parser would be cooler.

@code-asher code-asher force-pushed the asher/git-urls branch 4 times, most recently from 1d701db to c00960e Compare May 14, 2024 00:03
Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just had two questions about non-critical stuff

@code-asher code-asher merged commit 2fd0959 into main May 14, 2024
@code-asher code-asher deleted the asher/git-urls branch May 14, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Devcontainers plugin: Plugin is not able to process GitLab URLs correctly
2 participants