Parse git urls #127
Merged
Parse git urls #127
+177
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1d701db to
c00960e
Compare
code-asher
commented
May 14, 2024
plugins/backstage-plugin-devcontainers-react/src/hooks/useDevcontainers.ts
Outdated
Show resolved
Hide resolved
c00960e to
58d3906
Compare
Parkreiner
approved these changes
May 14, 2024
plugins/backstage-plugin-devcontainers-react/src/hooks/useDevcontainers.ts
Outdated
Show resolved
Hide resolved
Accidentally added it as a run-time dependency.
799f7bc to
63b34b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #117
As part of this, I moved the VS Code URI to an annotation during the processing phase.
I decided to go with a dependency over hand-rolling because there are quite a few forges that it supports and it did not seem worthwhile to figure all that out again if someone has already done it, and the code looks reasonable to me although I do still think a go-chi style of parser would be cooler.