Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Chore: Address race condition in channel.go #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
greyscaled opened this issue Apr 19, 2022 · 0 comments · Fixed by #1270
Closed

Chore: Address race condition in channel.go #1076

greyscaled opened this issue Apr 19, 2022 · 0 comments · Fixed by #1270
Assignees
@kylecarbs
Labels
api Area: HTTP API
Milestone
V2 Beta

Comments

@greyscaled
Copy link
Contributor

Overview

This was created from a TODO comment:

// TODO (@kyle): There's an obvious race-condition here.
// This is an edge-case, as most-frequently data won't
// be pooled so synchronously, but is definitely possible.
//
// See: https://github.com/pion/sctp/issues/181

See also #1066
@greyscaled greyscaled mentioned this issue Apr 19, 2022
Merged
kylecarbs added a commit that referenced this issue May 3, 2022
@kylecarbs
fix: Remove microsecond wait in peer.(*Channel)
815ef0b 
This was implemented when our WebRTC code was much less hardened.
It's likely this was a cause of some other problem.

Closes #1076.
@kylecarbs kylecarbs mentioned this issue May 3, 2022
Merged
kylecarbs added a commit that referenced this issue May 3, 2022
@kylecarbs
fix: Remove microsecond wait in peer.(*Channel) (#1270)
60aa40a 
This was implemented when our WebRTC code was much less hardened.
It's likely this was a cause of some other problem.

Closes #1076.
@misskniss misskniss added this to the V2 Beta milestone May 5, 2022
kylecarbs added a commit that referenced this issue Jun 10, 2022
@kylecarbs
fix: Remove microsecond wait in peer.(*Channel) (#1270)
9f5c864 
This was implemented when our WebRTC code was much less hardened.
It's likely this was a cause of some other problem.

Closes #1076.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kylecarbs kylecarbs

Labels
api Area: HTTP API
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging a pull request may close this issue.

fix: Remove microsecond wait in peer.(*Channel) coder/coder
3 participants
@misskniss @kylecarbs @greyscaled