Thanks to visit codestin.com
Credit goes to github.com

Skip to content

panic: TestSSH/ExitOnStop #10849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mtojek opened this issue Nov 23, 2023 · 1 comment · Fixed by #10859
Closed

panic: TestSSH/ExitOnStop #10849

mtojek opened this issue Nov 23, 2023 · 1 comment · Fixed by #10859
Assignees
@mafredri

Comments

@mtojek
Copy link
Member

mtojek commented Nov 23, 2023

Spotted in: https://github.com/coder/coder/actions/runs/6972047158/job/18973430969?pr=10845

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x3cba729]

goroutine 51993 [running]:
github.com/coder/coder/v2/coderd.(*API).watchWorkspace.func2({0x0?, 0x0?}, {0x0?, 0x0?, 0x0?})
	/home/runner/actions-runner/_work/coder/coder/coderd/workspaces.go:1222 +0x349
github.com/coder/coder/v2/coderd/database/pubsub.genericListener.send({0xc018dcb290?, 0x0?}, {0x71ee290, 0xc000138008}, {0x8cfaa28, 0x0, 0x0})
	/home/runner/actions-runner/_work/coder/coder/coderd/database/pubsub/pubsub_memory.go:18 +0x84
github.com/coder/coder/v2/coderd/database/pubsub.(*MemoryPubsub).Publish.func1()
	/home/runner/actions-runner/_work/coder/coder/coderd/database/pubsub/pubsub_memory.go:79 +0xfa
created by github.com/coder/coder/v2/coderd/database/pubsub.(*MemoryPubsub).Publish
	/home/runner/actions-runner/_work/coder/coder/coderd/database/pubsub/pubsub_memory.go:77 +0x214
@mtojek mtojek added the bug label Nov 23, 2023
@johnstcn johnstcn added the flake label Nov 23, 2023
@mafredri
Copy link
Member

Also https://github.com/coder/coder/actions/runs/6980355007/job/18995435295

@mafredri mafredri mentioned this issue Nov 24, 2023
Merged
mafredri added a commit that referenced this issue Nov 24, 2023
@mafredri
fix(coderd): remove nil ptr deref in watchWorkspace
1026e97 
Fixes #10849
mafredri added a commit that referenced this issue Nov 24, 2023
@mafredri
fix(coderd): remove nil ptr deref in watchWorkspace (#10859)
e73901c 
Fixes #10849
ericpaulsen pushed a commit to lbi22/coder that referenced this issue Nov 27, 2023
@mafredri @ericpaulsen
fix(coderd): remove nil ptr deref in watchWorkspace (coder#10859)
dc5f3cc 
Fixes coder#10849
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(coderd): remove nil ptr deref in watchWorkspace coder/coder
3 participants
@mafredri @johnstcn @mtojek