-
Notifications
You must be signed in to change notification settings - Fork 881
Show Initiator in Build Logs #2029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I will add |
#2174 adds the |
Should we add a Does anyone oppose adding a |
I'm a fan of this. I'm uncertain whether having it in the database is best, or making it a static UUID instead like reserving |
@kylecarbs I was thinking a special uuid, but if we have foreign key relations setup, we will need a row in the db to satisfy constraints. I imagine we'd do both. Use a special uuid, and insert into the db. |
@kylecarbs @Emyrk Just wanted to reach a decision on the discussion here. Considering the foreign key behavior of |
I'd also prefer non-null. |
Keep it non-null. I'm curious if we ever need to distinguish between initiated_by being Would be nice to know it started because of |
I understand if it is really out there, but I'd love for it to be named |
|
I like both |
The column name in the UI can be called |
The separate column idea, which is totally optional right now, is because we might have multiple reasons to perform a particular action. For instance, a workspace could get (re)started or built as part of administrators forcing all workspaces to update the project. |
That makes sense. This looks like a separate issue of its own though. I wonder if we'd wanna figure out the reasons ourselves, or let admins/users input their reasons when taking the action. In case we end up always assigning the same reason when the initiator is the same, it would seem moot to add the column. |
Yep, can be separate. |
I also like the idea of coloring this user differently when it appears in the UI. |
+1 on "system" and +1000 on different color |
#2428 adds a system user with a special uuid. |
There have been cases where either:
And it's unclear why a workspace transitioned state. I used this opaqueness to troll Kyle for multiple days.
I suggest we add an
"Actor"Initiated By column to the Timeline table in the Workspace page and an Actor field on the Build Log page.Implementation notes:
We should add a system user here to report in the logs for what user is taking what actions.
AC
Show a human readable name for the initiator ID for all builds.
Add another column in the build logs for initiator
Testing: storybook for UI, human readable name, check that the name appears on the page, unit test for API returning human readable name
The text was updated successfully, but these errors were encountered: