Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Metrics Support - Enterprise #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
misskniss opened this issue Mar 17, 2022 · 2 comments
Closed
1 of 2 tasks

Metrics Support - Enterprise #477

misskniss opened this issue Mar 17, 2022 · 2 comments

Comments

@misskniss
Copy link

misskniss commented Mar 17, 2022

Breakout Discussion

March 24, 2022
RFC



Primary metrics to start: (Post MVP)

  • users
  • make the V1 actve_users (Workspace agent last connected at):
    active_daily_users
    active_hourly_users
    Beyond those, this will be a paid feature. Post MVP.

Early Discussions:

  • [port the users and active_users over for V2 from V1
  • data model
  • Make the active-users event an hourly aggregated event.
  • create table for metric events
  • add corresponding models from v1 for the users and active_users metrics event
  • port over the metrics pusher from V1
  • add calls to metrics pusher where we need them
  • Add API endpoints to read data from the tables
  • scope out the cleanup operation
  • support for max age of the data in the database (maybe a cron job or something to insert bulk metrics on an interval like an hour or some other time frame?) How do we make it so we don't have to aggregate a bunch of data. NOTE: maintain the data and frequency that Palatir is currently using. Don't add an event every time it happens, filter and collapse the data.
  • Use the API key hourly refresh rate to help with the user metrics? What if users have multiple keys? join with owner and select account for query - for active_daily_users and active_houly_users. Nice optimization to reduce database row bloat.
  • Concerned about the side effect of a user connecting a BUNCH of times through SSH or similar.
  • clean up job to clear out old date to maintain the max number of rows or date cutoff for created date on the data

Frontend (post MVP)
UI / Dashboard would be PAID
We will get customers using V2 and the metrics now and then get feedback based on user input and needs.

  • Ability to embed a URL from their own metrics service that they are using for collecting
  • Export as CVS
  • CLI tool for ASCII grahp
@misskniss
Copy link
Author

@tjcran this may need the discussion notes broken out into issues. We should sync on this and see if they are all still relevant tasks.

@misskniss misskniss changed the title Metrics Support Metrics Support - Enterprise Jun 3, 2022
@kylecarbs
Copy link
Member

I'm going to close this for now. There isn't a ton of substance in the issue that we can work from, and it probably needs more investigation from @tjcran before we'd give it the green light.

@kylecarbs kylecarbs closed this as not planned Won't fix, can't repro, duplicate, stale Jul 18, 2022
brettkolodny pushed a commit that referenced this issue Mar 18, 2025
This fixes issue #477 where the error message when deleting an organization that
still has resources incorrectly references deleted resources with a zero value.
Now, only resources that actually exist will be mentioned in the error message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants