Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Set the theme to dark mode throughout the app #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks
Tracked by #803
misskniss opened this issue Mar 30, 2022 · 5 comments
Closed
2 tasks
Tracked by #803

Set the theme to dark mode throughout the app #699

misskniss opened this issue Mar 30, 2022 · 5 comments
Assignees
Labels
site Area: frontend dashboard
Milestone

Comments

@misskniss
Copy link

misskniss commented Mar 30, 2022

Use dark mode everywhere!

  • set it as the default theme in the app
  • set it in storybook
@misskniss misskniss added this to the V2 Beta milestone Mar 30, 2022
@presleyp
Copy link
Contributor

@misskniss is it okay if we just do the default dark mode and not have this as a separate ticket?

@misskniss
Copy link
Author

misskniss commented Apr 1, 2022

@presleyp Yeah. I was not sure how the login page is set up in relation to all the authenticated pages. So I have an epic of global dark mode (for authed pages) and then this one as a separate item. Feel free to adjust this plan as you see fit. As of today, the global dark mode work is slated for sprint 10 in the Community MVP milestone.

I will move this ticket under the global epic and set it to sprint 10 for now.

@misskniss misskniss modified the milestones: V2 Beta, Community MVP Apr 1, 2022
@presleyp presleyp changed the title Make the page background for the login screen dark mode Set the theme to dark mode throughout the app Apr 1, 2022
@presleyp
Copy link
Contributor

presleyp commented Apr 1, 2022

There's just one theme for all the pages, so we don't need to do login and other pages separately. But this was the only ticket in the dark mode epic so I just changed it to be the global one.

@misskniss misskniss added the site Area: frontend dashboard label May 5, 2022
@misskniss misskniss assigned Kira-Pilot and unassigned presleyp May 10, 2022
@greyscaled
Copy link
Contributor

See #803 (comment)

@misskniss
Copy link
Author

fixed by #1450

@misskniss misskniss assigned kylecarbs and unassigned Kira-Pilot May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site Area: frontend dashboard
Projects
None yet
Development

No branches or pull requests

5 participants