Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Coder server should fail (or health check) if the internal derp server is disabled and there are no custom derps #7173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #8971
deansheather opened this issue Apr 17, 2023 · 2 comments · Fixed by #10536
Closed
Tracked by #8971

Coder server should fail (or health check) if the internal derp server is disabled and there are no custom derps #7173

deansheather opened this issue Apr 17, 2023 · 2 comments · Fixed by #10536
Assignees
@deansheather
Labels
networking Area: networking s2 Broken use cases or features (with a workaround). Only humans may set this.
Milestone
healthcheck GA

Comments

@deansheather
Copy link
Member

Currently if you specify --derp-server-enable=false and no custom derps, no connections to workspaces will work. Coder should fail to start if there are no derps configured.

This caused a customer to be stuck for a while.
@sharkymark
Copy link
Contributor

yep ran into this

@bpmct bpmct added the s2 Broken use cases or features (with a workaround). Only humans may set this. label Apr 27, 2023
@sreya sreya added this to the ❓Sprint 1 milestone Jun 12, 2023
@bpmct bpmct mentioned this issue Aug 10, 2023
Closed
16 tasks
@bpmct bpmct changed the title Coder server should fail if the internal derp server is disabled and there are no custom derps Coder server should fail (or health check) if the internal derp server is disabled and there are no custom derps Aug 25, 2023
@bpmct
Copy link
Member

bpmct commented Aug 25, 2023

I'd be down to keep the server alive but show a health check banner too. Modified

@spikecurtis spikecurtis added the networking Area: networking label Sep 26, 2023
@deansheather deansheather mentioned this issue Nov 6, 2023
Merged
@johnstcn johnstcn mentioned this issue Jan 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deansheather deansheather

Labels
networking Area: networking s2 Broken use cases or features (with a workaround). Only humans may set this.
Projects
None yet
Milestone
healthcheck GA
Development

Successfully merging a pull request may close this issue.

fix: fail server startup on invalid DERP map coder/coder
6 participants
@sharkymark @sreya @spikecurtis @matifali @deansheather @bpmct