Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Convert UI light theme to dark theme #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
misskniss opened this issue Apr 1, 2022 · 1 comment
Closed
1 task done

Convert UI light theme to dark theme #803

misskniss opened this issue Apr 1, 2022 · 1 comment
Labels
site Area: frontend dashboard
Milestone
Community MVP

Comments

@misskniss
Copy link

misskniss commented Apr 1, 2022 •
edited by greyscaled
Loading

User Context 👥

As a user, I want the product theme to be dark all the time so that my eyes are not assaulted by bright white.
@misskniss misskniss added this to the Community MVP milestone Apr 1, 2022
@misskniss misskniss added the epic label Apr 1, 2022
@misskniss misskniss mentioned this issue Apr 1, 2022
Closed
2 tasks
@misskniss misskniss added the site Area: frontend dashboard label May 5, 2022
@greyscaled greyscaled changed the title Support for global dark mode only in the UI Convert UI light theme to dark theme May 12, 2022
@greyscaled
Copy link
Contributor

Note from Discord breakout:

  • Epic may not be needed since this is a 1-liner switch here:

coder/site/src/app.tsx

Line 34 in 26b04cc

<ThemeProvider theme={light}>

and possibly something in Storybook needs adjusting here:

coder/site/.storybook/preview.js

Lines 8 to 17 in 26b04cc

import "../src/theme/globalFonts"
const providerFn = ({ children, theme }) => (
<ThemeProvider theme={theme}>
<CssBaseline />
{children}
</ThemeProvider>
)
addDecorator(withThemes(null, [light, dark], { providerFn }))

I'm going to repeat this comment in #699

If it happens that we find inconsistencies, hard-coded colors or things that don't look well/haven't been converted to the dark theme well yet, we can add those as separate issues here.

@greyscaled greyscaled mentioned this issue May 14, 2022
Closed
@Kira-Pilot Kira-Pilot removed their assignment May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
site Area: frontend dashboard
Projects
None yet
Milestone
Community MVP
Development

No branches or pull requests
4 participants
@presleyp @misskniss @greyscaled @Kira-Pilot