Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: prevent alt text from appearing if OIDC icon fail to load #10792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 20, 2023
Merged

fix: prevent alt text from appearing if OIDC icon fail to load #10792

merged 3 commits into from
Nov 20, 2023

Conversation

Parkreiner
Copy link
Member

@Parkreiner Parkreiner commented Nov 20, 2023 •
edited
Loading

Changes made

  • Makes it so that if an OIDC icon fails to load on the login page, the alt text will not appear in the UI (but the text will still be available to screen readers)

Next steps

  • Just because we're using this special alt-text workaround in a few places, I feel like we should extract things out into a reusable component pretty soon

@Parkreiner Parkreiner self-assigned this Nov 20, 2023
cdr-bot[bot]
cdr-bot bot approved these changes Nov 20, 2023
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@Parkreiner Parkreiner changed the title fix: Prevent alt text from appearing if OIDC icon fail to load fix: prevent alt text from appearing if OIDC icon fail to load Nov 20, 2023
@Parkreiner Parkreiner merged commit df4f34a into main Nov 20, 2023
@Parkreiner Parkreiner deleted the mes/bugs/login-icon-alt-text branch November 20, 2023 15:51
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@Parkreiner Parkreiner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Parkreiner