Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: prevent alt text from appearing if OIDC icon fail to load #10792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 20, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: add visually hidden CSS
  • Loading branch information
Parkreiner committed Nov 20, 2023
commit 50113f25fcc9d211c7e157653b92700be3e8a19c
7 changes: 5 additions & 2 deletions site/src/pages/LoginPage/OAuthSignInForm.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@ import Button from "@mui/material/Button";
import GitHubIcon from "@mui/icons-material/GitHub";
import KeyIcon from "@mui/icons-material/VpnKey";
import Box from "@mui/material/Box";
import { useId, type FC } from "react";
import { useId, type FC, CSSProperties } from "react";
import { Language } from "./SignInForm";
import { type AuthMethods } from "api/typesGenerated";
import { visuallyHidden } from "@mui/utils";

type OAuthSignInFormProps = {
isSigningIn: boolean;
Expand Down Expand Up @@ -81,7 +82,9 @@ function OidcIcon({ iconUrl }: OidcIconProps) {
return (
<>
<img alt="" src={iconUrl} css={iconStyles} aria-labelledby={oidcId} />
<div id={oidcId}>Open ID Connect</div>
<div id={oidcId} css={{ ...visuallyHidden }}>
Open ID Connect
</div>
</>
);
}