Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: fix TestServiceBanners/Agent #11768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 29, 2024
Merged

fix: fix TestServiceBanners/Agent #11768

merged 2 commits into from
Jan 29, 2024

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Jan 23, 2024 •
edited
Loading

The original test is bugged in that it

  1. creates a new AGPL coderd with a new database, so no appearance is set in the DB.
  2. overwrites the agentClient so the assertion after removing the license is against the AGPL coderd

This was referenced Jan 23, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Jan 23, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@spikecurtis Graphite App
Copy link
Contributor Author

spikecurtis commented Jan 23, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spikecurtis and the rest of your teammates on Graphite Graphite

This was referenced Jan 23, 2024
Merged
Merged
@spikecurtis spikecurtis marked this pull request as ready for review January 23, 2024 10:22
code-asher
code-asher approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh that makes sense, I really misunderstood the client setup. Thank you for fixing!

@spikecurtis spikecurtis force-pushed the spike/10533-codersdk-derp-map branch from ffbd488 to 05b6c81 Compare January 23, 2024 18:25
@spikecurtis spikecurtis force-pushed the spike/10534-service-banners-test branch from 5c875b2 to f168e58 Compare January 23, 2024 18:25
@spikecurtis spikecurtis force-pushed the spike/10533-codersdk-derp-map branch from 05b6c81 to 7218a92 Compare January 24, 2024 10:26
@spikecurtis spikecurtis force-pushed the spike/10534-service-banners-test branch from f168e58 to faa1f29 Compare January 24, 2024 10:26
@spikecurtis spikecurtis mentioned this pull request Jan 24, 2024
Merged
@spikecurtis spikecurtis force-pushed the spike/10533-codersdk-derp-map branch from 7218a92 to 7297387 Compare January 24, 2024 12:55
@spikecurtis spikecurtis force-pushed the spike/10534-service-banners-test branch from faa1f29 to e980510 Compare January 24, 2024 12:56
@spikecurtis spikecurtis mentioned this pull request Jan 24, 2024
Merged
@spikecurtis spikecurtis force-pushed the spike/10533-codersdk-derp-map branch from 7297387 to 280a501 Compare January 25, 2024 11:23
@spikecurtis spikecurtis force-pushed the spike/10534-service-banners-test branch from e980510 to eaabdb7 Compare January 25, 2024 11:24
@spikecurtis spikecurtis mentioned this pull request Jan 25, 2024
Merged
@spikecurtis spikecurtis force-pushed the spike/10533-codersdk-derp-map branch from 280a501 to bfbb557 Compare January 26, 2024 06:47
@spikecurtis spikecurtis force-pushed the spike/10534-service-banners-test branch from eaabdb7 to 6a70ddf Compare January 26, 2024 06:47
@spikecurtis spikecurtis force-pushed the spike/10533-codersdk-derp-map branch from bfbb557 to 5abcdd4 Compare January 26, 2024 09:24
@spikecurtis spikecurtis force-pushed the spike/10534-service-banners-test branch from 6a70ddf to c980d65 Compare January 26, 2024 09:24
This was referenced Jan 26, 2024
Merged
Merged
@spikecurtis spikecurtis force-pushed the spike/10533-codersdk-derp-map branch from 5abcdd4 to 0a384f2 Compare January 26, 2024 15:27
@spikecurtis spikecurtis force-pushed the spike/10534-service-banners-test branch from c980d65 to 38f23ea Compare January 26, 2024 15:27
Base automatically changed from spike/10533-codersdk-derp-map to main January 29, 2024 07:26
@spikecurtis spikecurtis merged commit 37e9479 into main Jan 29, 2024
@spikecurtis spikecurtis deleted the spike/10534-service-banners-test branch January 29, 2024 07:56
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@code-asher code-asher code-asher approved these changes

Assignees

@spikecurtis spikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spikecurtis @code-asher