Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: remove legacy wsconncache #11816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2024
Merged

chore: remove legacy wsconncache #11816

merged 1 commit into from
Jan 30, 2024

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Jan 25, 2024 •
edited
Loading

Fixes #8218

Removes wsconncache and related "is legacy?" functions and API calls that were used by it.

The only leftover is that Agents still use the legacy IP, so that back level clients or workspace proxies can dial them correctly.

We should eventually remove this: #11819

This was referenced Jan 25, 2024
Merged
Merged
Merged
Merged
Merged
@spikecurtis Graphite App
Copy link
Contributor Author

spikecurtis commented Jan 25, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spikecurtis and the rest of your teammates on Graphite Graphite

@spikecurtis spikecurtis mentioned this pull request Jan 25, 2024
Merged
@spikecurtis spikecurtis marked this pull request as ready for review January 25, 2024 11:25
@spikecurtis spikecurtis force-pushed the spike/8218-remove-wsconncache branch 2 times, most recently from ca4dd7a to 00d8daa Compare January 25, 2024 11:40
@spikecurtis spikecurtis force-pushed the spike/10534-service-banner branch from 4dc08bc to 6e7e25f Compare January 25, 2024 12:30
@spikecurtis spikecurtis mentioned this pull request Jan 26, 2024
Closed
@spikecurtis spikecurtis force-pushed the spike/10534-service-banner branch from 6e7e25f to c4af306 Compare January 26, 2024 06:47
@spikecurtis spikecurtis force-pushed the spike/8218-remove-wsconncache branch from 00d8daa to dca0e6c Compare January 26, 2024 06:47
@spikecurtis spikecurtis force-pushed the spike/10534-service-banner branch from c4af306 to 4579eae Compare January 26, 2024 09:24
@spikecurtis spikecurtis force-pushed the spike/8218-remove-wsconncache branch from dca0e6c to 6fcd156 Compare January 26, 2024 09:24
This was referenced Jan 26, 2024
Merged
Merged
@spikecurtis spikecurtis force-pushed the spike/8218-remove-wsconncache branch from 6fcd156 to 1f928bd Compare January 26, 2024 09:40
@spikecurtis spikecurtis force-pushed the spike/10534-service-banner branch from 4579eae to 7961d48 Compare January 26, 2024 15:28
@spikecurtis spikecurtis force-pushed the spike/8218-remove-wsconncache branch from 1f928bd to 395f862 Compare January 26, 2024 15:28
@spikecurtis spikecurtis force-pushed the spike/10534-service-banner branch from 7961d48 to 04cdbc1 Compare January 29, 2024 07:58
@spikecurtis spikecurtis force-pushed the spike/8218-remove-wsconncache branch from 395f862 to 5798ab2 Compare January 29, 2024 07:58
@spikecurtis spikecurtis force-pushed the spike/10534-service-banner branch from 04cdbc1 to 320f232 Compare January 29, 2024 10:44
@spikecurtis spikecurtis force-pushed the spike/8218-remove-wsconncache branch from 5798ab2 to 903844a Compare January 29, 2024 10:44
@spikecurtis spikecurtis mentioned this pull request Jan 29, 2024
Merged
@spikecurtis spikecurtis force-pushed the spike/10534-service-banner branch from 320f232 to 492a7d4 Compare January 29, 2024 12:31
@spikecurtis spikecurtis force-pushed the spike/8218-remove-wsconncache branch from 903844a to fa421d2 Compare January 29, 2024 12:31
@spikecurtis spikecurtis mentioned this pull request Jan 29, 2024
Merged
@spikecurtis spikecurtis force-pushed the spike/10534-service-banner branch from 492a7d4 to a401924 Compare January 30, 2024 03:36
@spikecurtis spikecurtis force-pushed the spike/8218-remove-wsconncache branch from fa421d2 to 557df04 Compare January 30, 2024 03:36
Base automatically changed from spike/10534-service-banner to main January 30, 2024 03:44
@spikecurtis spikecurtis force-pushed the spike/8218-remove-wsconncache branch from 557df04 to 1444bef Compare January 30, 2024 03:45
@spikecurtis Graphite App
Copy link
Contributor Author

spikecurtis commented Jan 30, 2024 •
edited
Loading

Merge activity

  • Jan 29, 10:45 PM: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • Jan 29, 10:56 PM: @spikecurtis merged this pull request with Graphite.

@spikecurtis spikecurtis merged commit 1e8a9c0 into main Jan 30, 2024
@spikecurtis spikecurtis deleted the spike/8218-remove-wsconncache branch January 30, 2024 03:56
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@coadler coadler coadler approved these changes

@deansheather deansheather deansheather approved these changes

Assignees

@spikecurtis spikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove wsconncache after migration period
3 participants
@spikecurtis @coadler @deansheather