chore: implement wildcard style matching for build param values #12695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
8112eb2 to
aecf9c0
Compare
This was referenced Mar 20, 2024
ad20f9c to
d4fb951
Compare
aca699c to
2bcdbd9
Compare
d4fb951 to
9618597
Compare
2bcdbd9 to
819e861
Compare
|
I am going to close this because it makes our search terms more inconsistent. We can reopen this if we decide we need it in the future. It mainly is helpful for list style params. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows using
*to match wildcard type regex. This is useful because we allow list types in our param values. Without this if you had a list option, it would be tricky to match all params that contain some element in the list.Demo:
Screencast.from.2024-03-20.15-10-49.webm
The Problem
Only this 'param' term supports this right now. Others do not, so it's not consistent across all other search terms.