Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: prevent extending if template disallows #13182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 8, 2024
Merged

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma commented May 6, 2024

Closes #13078

@BrunoQuaresma BrunoQuaresma changed the title fix: don't allow extend if template doesn't allow fix: prevent extending if template disallows May 6, 2024
@BrunoQuaresma BrunoQuaresma marked this pull request as draft May 6, 2024 18:12
@BrunoQuaresma BrunoQuaresma requested a review from aslilac May 6, 2024 18:13
@BrunoQuaresma BrunoQuaresma marked this pull request as ready for review May 6, 2024 19:03
@BrunoQuaresma BrunoQuaresma requested review from mafredri, mtojek and a team May 6, 2024 19:03
Copy link

github-actions bot commented May 6, 2024


✔️ PR 13182 Updated successfully.
🚀 Access the credentials here.

cc: @BrunoQuaresma

@BrunoQuaresma
Copy link
Collaborator Author

@stirby I would appreciate your QA on this PR since auto stop has been a sensitive feature.

Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny flake in TestWorkspaceProxyWorkspaceApps_BlockDirect/PortSharing/HTTPS but unrelated 👍

@stirby
Copy link
Collaborator

stirby commented May 8, 2024

@BrunoQuaresma this is great - simple and clean solution. Validated the behavior in preview deployment, nice work.

@BrunoQuaresma BrunoQuaresma merged commit 24448e7 into main May 8, 2024
30 checks passed
@BrunoQuaresma BrunoQuaresma deleted the bq/fix-auto-stop branch May 8, 2024 15:58
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Template-enforced autostop can be overridden in the UI
5 participants