-
Notifications
You must be signed in to change notification settings - Fork 886
fix: prevent extending if template disallows #13182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✔️ PR 13182 Updated successfully.
|
@stirby I would appreciate your QA on this PR since auto stop has been a sensitive feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny flake in TestWorkspaceProxyWorkspaceApps_BlockDirect/PortSharing/HTTPS
but unrelated 👍
Co-authored-by: Mathias Fredriksson <[email protected]>
…o bq/fix-auto-stop
@BrunoQuaresma this is great - simple and clean solution. Validated the behavior in preview deployment, nice work. |
Closes #13078